Issue 10873043: Pending relation line issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10873043: Pending relation line issues

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by matthew.scott

Modified:
10 years, 10 months ago

Reviewers:
benji, jeff.pihach, mp+172602

Visibility:
Public.

Description

Pending relation line issues This fixes the pending relation line issues by taking the mouse cursor's position relative to an absolutely position element (the first g (Grouping) element within the SVG element) rather than a relatively positioned element (the zoom-plane rect element). The test surrounding pending relations from the add-rel button now tests relation endpoints. https://code.launchpad.net/~makyo/juju-gui/rel-fix/+merge/172602 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Pending relation line issues #

Total comments: 2

Patch Set 3 : Pending relation line issues #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/relation.js	View	1 2	3 chunks	+12 lines, -5 lines	0 comments	Download
M	test/test_environment_view.js	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

benji

LGTM. It would be great if there were a test we could write for this. ...

10 years, 10 months ago (2013-07-02 15:53:19 UTC) #2

benji

On 2013/07/02 15:53:19, benji wrote: > LGTM. It would be great if there were a ...

10 years, 10 months ago (2013-07-02 15:53:32 UTC) #3

jeff.pihach

LGTM - thanks for this fix! https://codereview.appspot.com/10873043/diff/6001/app/views/topology/relation.js File app/views/topology/relation.js (right): https://codereview.appspot.com/10873043/diff/6001/app/views/topology/relation.js#newcode995 app/views/topology/relation.js:995: @property {d3ns.Component} component ...

10 years, 10 months ago (2013-07-02 15:56:54 UTC) #5

matthew.scott

10 years, 10 months ago (2013-07-02 16:56:31 UTC) #6

*** Submitted:

Pending relation line issues

This fixes the pending relation line issues by taking the mouse cursor's
position relative to an absolutely position element (the first g (Grouping)
element within the SVG element) rather than a relatively positioned element (the
zoom-plane rect element). The test surrounding pending relations from the
add-rel button now tests relation endpoints.

R=benji, jeff.pihach
CC=
https://codereview.appspot.com/10873043

Expand All Messages | Collapse All Messages