Fixes dd icons sticking around after drop

Fixes dd icons sticking around after drop

This also does a driveby fix to adjust the height
calculation for full screen service views and to not
apply position annotations during drag.

https://code.launchpad.net/~hatch/juju-gui/drag-icon-fix/+merge/172697

(do not edit description out of merge proposal)

[jeff.pihach, 2013-07-02 23:35:56]

Please take a look.

[matthew.scott, 2013-07-02 23:43:28]

LGTM - thanks for the fixes.

[rharding, 2013-07-02 23:46:16]

LGTM with a couple of naming suggestions and two 'double check' points please.

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:83: var dragImage, clonedIcon;
please newline this.

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:95: clonedIcon.setAttribute('id',
clonedIcon.get('_yuid'));
are we guaranteed to have a _yuid through cloneNode? Should we make sure to
generate/set one on it?

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:102: evt.dataTransfer.setData('clonedIcon',
clonedIcon.getAttribute('id'));
if this is an ID please call it clonedIconID to make clear on the other end what
it is.

https://codereview.appspot.com/10872044/diff/1/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/10872044/diff/1/test/test_service_module.js#ne...
test/test_service_module.js:384: return 'foo';
how is the id of the cloned icon node matching up the localContainer id?

[jeff.pihach, 2013-07-03 05:29:25]

Thanks for the reviews!

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:95: clonedIcon.setAttribute('id',
clonedIcon.get('_yuid'));
Yes every new call to Y.Node generates a new _yuid for the cache.

https://codereview.appspot.com/10872044/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:102: evt.dataTransfer.setData('clonedIcon',
clonedIcon.getAttribute('id'));
Good idea, done

https://codereview.appspot.com/10872044/diff/1/test/test_service_module.js
File test/test_service_module.js (right):

https://codereview.appspot.com/10872044/diff/1/test/test_service_module.js#ne...
test/test_service_module.js:384: return 'foo';
I set it to foo on line 375 above.

[jeff.pihach, 2013-07-03 05:31:22]

Please take a look.

[jeff.pihach, 2013-07-03 05:38:43]

*** Submitted:

Fixes dd icons sticking around after drop

This also does a driveby fix to adjust the height
calculation for full screen service views and to not
apply position annotations during drag.

R=matthew.scott, rharding
CC=
https://codereview.appspot.com/10872044