Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1858)

Issue 108710046: code review 108710046: crypto/tls: add ALPN support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by agl1
Modified:
5 years, 8 months ago
Reviewers:
mikio
CC:
bradfitz, mikio, golang-codereviews
Visibility:
Public.

Description

crypto/tls: add ALPN support. Fixes issue 6736.

Patch Set 1 #

Patch Set 2 : diff -r 27de92961f3e https://code.google.com/p/go #

Patch Set 3 : diff -r 27de92961f3e https://code.google.com/p/go #

Total comments: 4

Patch Set 4 : diff -r cf71e2f3f8b5 https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r fa8c762ef028 https://code.google.com/p/go #

Patch Set 6 : diff -r d92c94097e78 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -21 lines) Patch
M src/pkg/crypto/tls/common.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/crypto/tls/handshake_client.go View 4 chunks +41 lines, -8 lines 0 comments Download
M src/pkg/crypto/tls/handshake_client_test.go View 3 chunks +51 lines, -0 lines 0 comments Download
M src/pkg/crypto/tls/handshake_messages.go View 12 chunks +96 lines, -2 lines 0 comments Download
M src/pkg/crypto/tls/handshake_messages_test.go View 2 chunks +5 lines, -0 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server.go View 1 chunk +15 lines, -7 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 6 chunks +57 lines, -4 lines 0 comments Download
A src/pkg/crypto/tls/testdata/Client-TLSv12-ALPN View 1 chunk +97 lines, -0 lines 0 comments Download
A src/pkg/crypto/tls/testdata/Client-TLSv12-ALPN-NoMatch View 1 chunk +95 lines, -0 lines 0 comments Download
A src/pkg/crypto/tls/testdata/Server-TLSv12-ALPN View 1 chunk +122 lines, -0 lines 0 comments Download
A src/pkg/crypto/tls/testdata/Server-TLSv12-ALPN-NoMatch View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 8
agl1
Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 8 months ago (2014-07-18 19:00:20 UTC) #1
agl1
Brad: please patch this in and see whether it works for you. I'll be at ...
5 years, 8 months ago (2014-07-18 19:00:40 UTC) #2
bradfitz
https://codereview.appspot.com/108710046/diff/40001/src/pkg/crypto/tls/handshake_client_test.go File src/pkg/crypto/tls/handshake_client_test.go (right): https://codereview.appspot.com/108710046/diff/40001/src/pkg/crypto/tls/handshake_client_test.go#newcode53 src/pkg/crypto/tls/handshake_client_test.go:53: // ConnectionState of the resulting connection. It returns false ...
5 years, 8 months ago (2014-07-20 18:56:48 UTC) #3
agl1
https://codereview.appspot.com/108710046/diff/40001/src/pkg/crypto/tls/handshake_client_test.go File src/pkg/crypto/tls/handshake_client_test.go (right): https://codereview.appspot.com/108710046/diff/40001/src/pkg/crypto/tls/handshake_client_test.go#newcode53 src/pkg/crypto/tls/handshake_client_test.go:53: // ConnectionState of the resulting connection. It returns false ...
5 years, 8 months ago (2014-07-24 22:26:41 UTC) #4
mikio
rfc7301, yay! pls add "Fixes issue 6736." line to the cl descr. https://codereview.appspot.com/108710046/diff/60001/src/pkg/crypto/tls/handshake_client.go File src/pkg/crypto/tls/handshake_client.go ...
5 years, 8 months ago (2014-07-30 06:52:46 UTC) #5
agl1
https://codereview.appspot.com/108710046/diff/60001/src/pkg/crypto/tls/handshake_client.go File src/pkg/crypto/tls/handshake_client.go (right): https://codereview.appspot.com/108710046/diff/60001/src/pkg/crypto/tls/handshake_client.go#newcode44 src/pkg/crypto/tls/handshake_client.go:44: } On 2014/07/30 06:52:46, mikio wrote: > also need ...
5 years, 8 months ago (2014-08-01 21:07:33 UTC) #6
mikio
LGTM
5 years, 8 months ago (2014-08-03 02:30:36 UTC) #7
agl1
5 years, 8 months ago (2014-08-05 18:36:27 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=71dc1b4815f2 ***

crypto/tls: add ALPN support.

Fixes issue 6736.

LGTM=mikioh.mikioh
R=bradfitz, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/108710046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b