Update and re-activate Azure StateInfo() test.

Update and re-activate Azure StateInfo() test.

It's taking us rather long, compared to what we're used to with MAAS or
Launchpad, to get branches finished and landed.  And so Raphaël and I got
ourselves into a bit of a tangle with ongoing work, and the sanest way out
was to disable, temporarily, the happy-path StateInfo test.  We agreed that I
would get the test back up afterwards.

In this branch I re-enable that test, extending it to deal with the fact that
Instances() has now been properly implemented, where the test relied on a
stub.  Luckily it turned out to be just a matter of faking a gwacl/Azure
request-response pair to satisfy Instances().

https://code.launchpad.net/~jtv/juju-core/az-stateinfo-2/+merge/172555

(do not edit description out of merge proposal)

[jtv.canonical, 2013-07-02 13:13:23]

Please take a look.

[fwereade, 2013-07-02 15:29:43]

maybe I misunderstood this?

https://codereview.appspot.com/10869043/diff/1/environs/azure/environ_test.go
File environs/azure/environ_test.go (right):

https://codereview.appspot.com/10869043/diff/1/environs/azure/environ_test.go...
environs/azure/environ_test.go:325: c.Check(apiInfo.Addrs, DeepEquals,
[]string{instanceID + apiPortSuffix})
Can we write this so that instanceId != DNSName? I'm finding it a bit hard to
feel confident that this test is testing what we think it is.

[jtv.canonical, 2013-07-03 07:20:04]

On 2013/07/02 15:29:43, fwereade wrote:
> maybe I misunderstood this?

>
https://codereview.appspot.com/10869043/diff/1/environs/azure/environ_test.go...
> environs/azure/environ_test.go:325: c.Check(apiInfo.Addrs, DeepEquals,
> []string{instanceID + apiPortSuffix})
> Can we write this so that instanceId != DNSName? I'm finding it a bit hard to
> feel confident that this test is testing what we think it is.

In the Azure provider, the DNS name and the instance ID are the same thing. 
It's tied to how Azure works.  I added a comment to that effect.

[jtv.canonical, 2013-07-03 07:21:41]

Please take a look.

[jameinel, 2013-07-03 08:27:15]

LGTM

[fwereade, 2013-07-03 10:45:00]

LGTM