Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(514)

Issue 108640043: code review 108640043: runtime: remove dedicated scavenger thread (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by dvyukov
Modified:
10 years, 8 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc, khr, rlh
Visibility:
Public.

Description

runtime: remove dedicated scavenger thread A whole thread is too much for background scavenger that sleeps all the time anyway. We already have sysmon thread that can do this work. Also remove g->isbackground and simplify enter/exitsyscall.

Patch Set 1 #

Patch Set 2 : diff -r 67f9ef140028 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 6866fbf95095 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 6866fbf95095 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 6866fbf95095 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r d278a69e057f0c0858be3ec4237ce2eb62d9f33d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r d278a69e057f0c0858be3ec4237ce2eb62d9f33d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r d278a69e057f0c0858be3ec4237ce2eb62d9f33d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r d278a69e057f0c0858be3ec4237ce2eb62d9f33d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -92 lines) Patch
M src/pkg/runtime/heapdump.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/malloc.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 3 chunks +3 lines, -5 lines 0 comments Download
M src/pkg/runtime/mheap.c View 1 2 3 4 5 6 3 chunks +5 lines, -67 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 4 5 6 10 chunks +66 lines, -14 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/runtime/time.go View 1 2 3 4 5 7 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 9 months ago (2014-07-14 14:28:19 UTC) #1
rsc
LGTM
10 years, 8 months ago (2014-08-25 02:09:46 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=c157d3790300 *** runtime: remove dedicated scavenger thread A whole thread is too ...
10 years, 8 months ago (2014-08-25 17:00:01 UTC) #3
gobot
10 years, 8 months ago (2014-08-25 17:10:04 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the freebsd-amd64 builder.
See http://build.golang.org/log/c454fb92400fc16aac449934506e1210f68a0a41
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b