Issue 10858050: deployer: omitted suggestions from a prev review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10858050: deployer: omitted suggestions from a prev review (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dimitern

Modified:
10 years, 9 months ago

Reviewers:
gz, mp+173551, fwereade

Visibility:
Public.

Description

deployer: omitted suggestions from a prev review As promised in https://codereview.appspot.com/10746044/ I'm adding the omitted suggestions from fwereade's review. https://code.launchpad.net/~dimitern/juju-core/062-deployer-implement-omitted-suggestions/+merge/173551 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : deployer: omitted suggestions from a prev review #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent.go	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	worker/deployer/simple.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

LGTM, thanks for the closure :)

Expand All Messages | Collapse All Messages