Issue 10853043: code review 10853043: go.crypto/ssh/terminal: don't save passwords in history.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10853043: code review 10853043: go.crypto/ssh/terminal: don't save passwords in history. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by agl1

Modified:
10 years, 9 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

go.crypto/ssh/terminal: don't save passwords in history. The history buffer would recall previously entered lines: including passwords. With this change, lines entered while echo is disabled are no longer put into the history.

Patch Set 1 #

Patch Set 2 : diff -r 7f5a59ff6b43 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 7f5a59ff6b43 https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	ssh/terminal/terminal.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	ssh/terminal/terminal_test.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

10 years, 10 months ago (2013-07-02 00:43:57 UTC) #1

agl1

10 years, 9 months ago (2013-07-02 23:47:59 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=06b2614538ce&repo=crypto ***

go.crypto/ssh/terminal: don't save passwords in history.

The history buffer would recall previously entered lines: including passwords.
With this change, lines entered while echo is disabled are no longer put into
the history.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10853043

Expand All Messages | Collapse All Messages