allow uncommitted git changes to be uploaded

Allow uncommitted git changes to be uploaded.

The default for "git diff" is to diff the uncommitted changes, so I made this patch follow that norm. The default would be to allow uncommitted changes be part of upload (as it used to be before 1166). But this behavior can be turned off via the command line option --git_committed_only.

This also would fix issue 467 (Unable to do upload.py for a just created file).

[Andi, 2014-07-08 04:07:18]

[Removing myself as a reviewer, at the moment I don't have time for any reviews,
sorry...]

[M-A, 2014-07-26 18:05:06]

Jason, could you take on this review from there? I didn't confirm the CLA.

https://codereview.appspot.com/108430043/diff/1/upload.py
File upload.py (right):

https://codereview.appspot.com/108430043/diff/1/upload.py#newcode1655
upload.py:1655: if not self.options.git_committed_only and re.search("bad object
%s" % file_hash, err):
please make it fit 80 cols please.

[scott2, 2014-08-01 14:51:50]

On 2014/07/26 18:05:06, M-A wrote:
> Jason, could you take on this review from there? I didn't confirm the CLA.
> 
> https://codereview.appspot.com/108430043/diff/1/upload.py
> File upload.py (right):
> 
> https://codereview.appspot.com/108430043/diff/1/upload.py#newcode1655
> upload.py:1655: if not self.options.git_committed_only and re.search("bad
object
> %s" % file_hash, err):
> please make it fit 80 cols please.

I just filled in the CLA.

[vincentbastos, 2018-04-30 05:30:59]

Is this issue stuck? I can see that it is not closed, but I can't tell whether
this patch has been applied or not apart from the fact that I'm still getting
the same error.

[M-A, 2018-05-16 20:45:21]

We are not using this code anymore AFAIK.

Le lun. 30 avr. 2018, à 01 h 31, <vincentbastos@gmail.com> a écrit :

> Is this issue stuck? I can see that it is not closed, but I can't tell
> whether this patch has been applied or not apart from the fact that I'm
> still getting the same error.
>
> https://codereview.appspot.com/108430043/
>

[vibrujola, 2019-09-09 01:51:22]

A

[vibrujola, 2019-09-09 01:52:23]

On 2019/09/09 01:51:22, vibrujola wrote:
> A