Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(418)

Issue 108430043: allow uncommitted git changes to be uploaded

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by scott2
Modified:
1 month, 1 week ago
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Allow uncommitted git changes to be uploaded. The default for "git diff" is to diff the uncommitted changes, so I made this patch follow that norm. The default would be to allow uncommitted changes be part of upload (as it used to be before 1166). But this behavior can be turned off via the command line option --git_committed_only. This also would fix issue 467 (Unable to do upload.py for a just created file).

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M upload.py View 2 chunks +11 lines, -2 lines 1 comment Download

Messages

Total messages: 8
scott2
7 years, 6 months ago (2014-07-07 22:01:53 UTC) #1
Andi
[Removing myself as a reviewer, at the moment I don't have time for any reviews, ...
7 years, 6 months ago (2014-07-08 04:07:18 UTC) #2
M-A
Jason, could you take on this review from there? I didn't confirm the CLA. https://codereview.appspot.com/108430043/diff/1/upload.py ...
7 years, 5 months ago (2014-07-26 18:05:06 UTC) #3
scott2
On 2014/07/26 18:05:06, M-A wrote: > Jason, could you take on this review from there? ...
7 years, 5 months ago (2014-08-01 14:51:50 UTC) #4
vincentbastos
Is this issue stuck? I can see that it is not closed, but I can't ...
3 years, 8 months ago (2018-04-30 05:30:59 UTC) #5
M-A
We are not using this code anymore AFAIK. Le lun. 30 avr. 2018, à 01 ...
3 years, 8 months ago (2018-05-16 20:45:21 UTC) #6
vibrujola
A
2 years, 4 months ago (2019-09-09 01:51:22 UTC) #7
vibrujola
2 years, 4 months ago (2019-09-09 01:52:23 UTC) #8
On 2019/09/09 01:51:22, vibrujola wrote:
> A
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b