code review 108400045: runtime/cgo: replace fprintf(stderr, ...) with fatalf(...)

runtime/cgo: replace fprintf(stderr, ...) with fatalf(...) for linux/android

Both stdout and stderr are sent to /dev/null in android
apps. Introducing fatalf allows android to implement its
own copy that sends fatal errors to __android_log_print.

[crawshaw, 2014-07-03 21:50:46]

Hello minux@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-07-03 23:16:11]

https://codereview.appspot.com/108400045/diff/40001/src/pkg/runtime/cgo/gcc_l...
File src/pkg/runtime/cgo/gcc_linux_arm.c (right):

https://codereview.appspot.com/108400045/diff/40001/src/pkg/runtime/cgo/gcc_l...
src/pkg/runtime/cgo/gcc_linux_arm.c:13: void (*x_cgo_fatalf)(const char*, ...);
what does this do? where it's initialized?

[crawshaw, 2014-07-03 23:22:42]

https://codereview.appspot.com/108400045/diff/40001/src/pkg/runtime/cgo/gcc_l...
File src/pkg/runtime/cgo/gcc_linux_arm.c (right):

https://codereview.appspot.com/108400045/diff/40001/src/pkg/runtime/cgo/gcc_l...
src/pkg/runtime/cgo/gcc_linux_arm.c:13: void (*x_cgo_fatalf)(const char*, ...);
On 2014/07/03 23:16:11, minux wrote:
> what does this do? where it's initialized?

remnant from an experiment. removed.

[minux, 2014-07-03 23:28:43]

LGTM.

[minux, 2014-07-03 23:29:36]

please add "for linux/android" to the description.

[dave_cheney.net, 2014-07-03 23:46:09]

LGTM (with minux's request).

Tested fine on darwin/amd64 and linux/arm on some odd arch linux derivative.

[crawshaw, 2014-07-04 01:05:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=aa480930f37e ***

runtime/cgo: replace fprintf(stderr, ...) with fatalf(...) for linux/android

Both stdout and stderr are sent to /dev/null in android
apps. Introducing fatalf allows android to implement its
own copy that sends fatal errors to __android_log_print.

LGTM=minux, dave
R=minux, dave
CC=golang-codereviews
https://codereview.appspot.com/108400045

[gobot, 2014-07-04 01:16:33]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/f75d828a68cdcbc7de0d056b9339d52b721dad1b