Issue 108400044: code review 108400044: crypto/x509: fix format strings in test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108400044: code review 108400044: crypto/x509: fix format strings in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dvyukov

Modified:
10 years, 11 months ago

Reviewers:
brainman

CC:
golang-codereviews, brainman

Visibility:
Public.

Description

crypto/x509: fix format strings in test Currently it says: --- PASS: TestDecrypt-2 (0.11s) pem_decrypt_test.go:17: test 0. %!s(x509.PEMCipher=1) --- PASS: TestEncrypt-2 (0.00s) pem_decrypt_test.go:42: test 0. %!s(x509.PEMCipher=1)

Patch Set 1 #

Patch Set 2 : diff -r 0f766178488c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 0f766178488c https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 04c9a977b540 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/crypto/x509/pem_decrypt_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 11 months ago (2014-07-03 07:12:53 UTC) #1

dvyukov

10 years, 11 months ago (2014-07-03 08:25:03 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b8fa05f72494 ***

crypto/x509: fix format strings in test
Currently it says:
--- PASS: TestDecrypt-2 (0.11s)
pem_decrypt_test.go:17: test 0. %!s(x509.PEMCipher=1)
--- PASS: TestEncrypt-2 (0.00s)
pem_decrypt_test.go:42: test 0. %!s(x509.PEMCipher=1)

LGTM=alex.brainman
R=golang-codereviews, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/108400044

Expand All Messages | Collapse All Messages