Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(611)

Issue 10839044: Add new download attribute to the related charms

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rharding
Modified:
11 years, 11 months ago
Reviewers:
curtis, mp+174258, benjamin.saller
Visibility:
Public.

Description

Add new download attribute to the related charms - Add the new attribute to the kept properites - Drive by to make the d3.status listed in merge-file to build. https://code.launchpad.net/~rharding/juju-gui/missing-downloads-1200193/+merge/174258 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add new download attribute to the related charms #

Patch Set 3 : Add new download attribute to the related charms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 chunk +1 line, -0 lines 0 comments Download
M bin/merge-files View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_model.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years, 11 months ago (2013-07-11 17:46:46 UTC) #1
benjamin.saller
LGTM Thanks for the drive by fix on the dep.
11 years, 11 months ago (2013-07-11 17:48:40 UTC) #2
curtis
LGTM, thanks.
11 years, 11 months ago (2013-07-11 17:51:51 UTC) #3
rharding
11 years, 11 months ago (2013-07-11 18:05:05 UTC) #4
*** Submitted:

Add new download attribute to the related charms

- Add the new attribute to the kept properites
- Drive by to make the d3.status listed in merge-file to build.

R=benjamin.saller, curtis
CC=
https://codereview.appspot.com/10839044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b