Issue 108330043: code review 108330043: cmd/gofmt: fix -s for 3-index slices

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108330043: code review 108330043: cmd/gofmt: fix -s for 3-index slices (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by gri

Modified:
10 years, 11 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

cmd/gofmt: fix gofmt -s for 3-index slices 3-index slices of the form s[:len(s):len(s)] cannot be simplified to s[::len(s)].

Patch Set 1 #

Patch Set 2 : diff -r 5f017e1d0129 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5f017e1d0129 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5f017e1d0129 https://code.google.com/p/go/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	src/cmd/gofmt/simplify.go	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/cmd/gofmt/testdata/slices1.golden	View	1	6 chunks	+6 lines, -0 lines	0 comments	Download
M	src/cmd/gofmt/testdata/slices1.input	View	1	6 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 11 months ago (2014-07-01 17:37:36 UTC) #1

gri

10 years, 11 months ago (2014-07-01 17:40:33 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=3e041f7ef9ff ***

cmd/gofmt: fix gofmt -s for 3-index slices

3-index slices of the form s[:len(s):len(s)]
cannot be simplified to s[::len(s)].

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/108330043

Expand All Messages | Collapse All Messages