Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(399)

Issue 10832043: Update the downloads to be total vs recent.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rharding
Modified:
10 years, 9 months ago
Reviewers:
curtis, benji, mp+172375
Visibility:
Public.

Description

Update the downloads to be total vs recent. - Update the json data files per the new api payload. - IGNORE then updated .json files in the test suite. - Update the model to include a new downloads attribute matching the api response. - Update the charm-token to display downlods vs the recent values. QA Known Issues ---------------- Currently the new api is only available in staging.jujucharms.com. This means that all download counts show as undefined when doing QA against the production back end. Since the browser is currently not visible to general users and the lack of the attribute does not throw errors of any kind, it's considered safe to land as the back end code is done and just needs to be deployed. https://code.launchpad.net/~rharding/juju-gui/total-downloads/+merge/172375 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update the downloads to be total vs recent. #

Patch Set 3 : Update the downloads to be total vs recent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -3382 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +2 lines, -2 lines 0 comments Download
M app/templates/charm-token.handlebars View 1 chunk +2 lines, -2 lines 0 comments Download
M app/widgets/charm-token.js View 2 chunks +7 lines, -7 lines 0 comments Download
M test/data/browsercharm.json View 6 chunks +39 lines, -1665 lines 0 comments Download
M test/data/related.json View 15 chunks +32 lines, -1696 lines 0 comments Download
M test/test_browser_charm_details.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_charm_token.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/test_charm_token_drag_and_drop.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_model.js View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 9 months ago (2013-07-01 17:48:08 UTC) #1
benji
LGTM
10 years, 9 months ago (2013-07-01 18:07:47 UTC) #2
curtis
LGTM. Thank you Rick.
10 years, 9 months ago (2013-07-01 18:24:43 UTC) #3
rharding
10 years, 9 months ago (2013-07-01 18:30:50 UTC) #4
*** Submitted:

Update the downloads to be total vs recent.

- Update the json data files per the new api payload. 
- IGNORE then updated .json files in the test suite.
- Update the model to include a new downloads attribute matching the api
response.
- Update the charm-token to display downlods vs the recent values.

QA Known Issues
----------------

Currently the new api is only available in staging.jujucharms.com. This means
that all download counts show as undefined when doing QA against the
production back end.

Since the browser is currently not visible to general users and the lack of
the attribute does not throw errors of any kind, it's considered safe to land
as the back end code is done and just needs to be deployed.

R=benji, curtis
CC=
https://codereview.appspot.com/10832043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b