Issue 10826044: code review 10826044: go/parser: more tolerant parsing of const decls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10826044: code review 10826044: go/parser: more tolerant parsing of const decls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by gri

Modified:
11 years, 12 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

go/parser: more tolerant parsing of const and var decls Instead, rely on the type checker.

Patch Set 1 #

Patch Set 2 : diff -r d0c957701447 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 79764384421c https://code.google.com/p/go #

Patch Set 4 : diff -r 79764384421c https://code.google.com/p/go #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/pkg/go/parser/parser.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	src/pkg/go/parser/short_test.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 12 months ago (2013-07-10 17:08:34 UTC) #1

adonovan

On 2013/07/10 17:08:34, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

11 years, 12 months ago (2013-07-10 18:08:04 UTC) #2

gri

11 years, 12 months ago (2013-07-10 19:01:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=246a365377ca ***

go/parser: more tolerant parsing of const and var decls

Instead, rely on the type checker.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/10826044

Expand All Messages | Collapse All Messages