Issue 108180043: code review 108180043: cmd/go: build non-runnable examples in xtests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108180043: code review 108180043: cmd/go: build non-runnable examples in xtests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by adg

Modified:
10 years, 11 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

cmd/go: build non-runnable examples in xtests Include these files in the build, even though they don't get executed.

Patch Set 1 #

Patch Set 2 : diff -r 41a383d40558 https://code.google.com/p/go #

Patch Set 3 : diff -r 363e78454ccd https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -18 lines)			Patch
M	src/cmd/go/test.bash	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1	6 chunks	+21 lines, -18 lines	0 comments	Download
A	src/cmd/go/testdata/norunexample/example_test.go	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/norunexample/test_test.go	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-06-25 04:31:31 UTC) #1

adg

10 years, 11 months ago (2014-06-27 21:15:26 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a6b828745f8e ***

cmd/go: build non-runnable examples in xtests

Include these files in the build,
even though they don't get executed.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/108180043

Expand All Messages | Collapse All Messages