code review 108150043: strings: avoid pointless slice growth in makeBenchInputHard

strings: avoid pointless slice growth in makeBenchInputHard

[josharian, 2014-06-26 18:26:55]

Hello golang-codereviews@googlegroups.com (cc: ruiu@google.com),

I'd like you to review this change to
https://code.google.com/p/go

[ruiu, 2014-06-26 18:31:29]

LGTM.

[josharian, 2014-06-26 20:00:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=baa0b6b4b248 ***

strings: avoid pointless slice growth in makeBenchInputHard

LGTM=ruiu
R=golang-codereviews, ruiu
CC=golang-codereviews
https://codereview.appspot.com/108150043

[gobot, 2014-06-27 06:47:48]

This CL appears to have broken the linux-arm-cheney-panda builder.
See http://build.golang.org/log/f372bb09490047621c00bd8aa10bd0d6b54f9815

[dave_cheney.net, 2014-06-27 06:48:25]

Interesting,

 # GOMAXPROCS=2 runtime -cpu=1,2,4

runtime: newstack called from g=0x10702460
m=0x10718580 m->curg=0x10702960 m->g0=0x10702500 m->gsignal=0x10702460
panic during panic

runtime stack:
runtime.startpanic()
/usr/local/go/src/pkg/runtime/panic.c:408 +0xc4
runtime.throw(0x523963)
/usr/local/go/src/pkg/runtime/panic.cBuild complete, duration
14m49.452484131s. Result: error: exit status 3

On Fri, Jun 27, 2014 at 4:47 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-arm-cheney-panda builder.
> See http://build.golang.org/log/f372bb09490047621c00bd8aa10bd0d6b54f9815
>
>
> https://codereview.appspot.com/108150043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[josharian, 2014-06-27 16:19:11]

Interesting, indeed. I'll try to reproduce and file an issue later today or
on Monday, if you don't beat me to it.


On Thu, Jun 26, 2014 at 11:48 PM, Dave Cheney <dave@cheney.net> wrote:

> Interesting,
>
>  # GOMAXPROCS=2 runtime -cpu=1,2,4
>
> runtime: newstack called from g=0x10702460
> m=0x10718580 m->curg=0x10702960 m->g0=0x10702500 m->gsignal=0x10702460
> panic during panic
>
> runtime stack:
> runtime.startpanic()
> /usr/local/go/src/pkg/runtime/panic.c:408 +0xc4
> runtime.throw(0x523963)
> /usr/local/go/src/pkg/runtime/panic.cBuild complete, duration
> 14m49.452484131s. Result: error: exit status 3
>
> On Fri, Jun 27, 2014 at 4:47 PM,  <gobot@golang.org> wrote:
> > This CL appears to have broken the linux-arm-cheney-panda builder.
> > See http://build.golang.org/log/f372bb09490047621c00bd8aa10bd0d6b54f9815
> >
> >
> > https://codereview.appspot.com/108150043/
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[josharian, 2014-06-28 22:30:56]

Reproduced (I think) on my Raspberry Pi, and filed issue 8298.


On Fri, Jun 27, 2014 at 9:18 AM, Josh Bleecher Snyder <josharian@gmail.com>
wrote:

> Interesting, indeed. I'll try to reproduce and file an issue later today
> or on Monday, if you don't beat me to it.
>
>
> On Thu, Jun 26, 2014 at 11:48 PM, Dave Cheney <dave@cheney.net> wrote:
>
>> Interesting,
>>
>>  # GOMAXPROCS=2 runtime -cpu=1,2,4
>>
>> runtime: newstack called from g=0x10702460
>> m=0x10718580 m->curg=0x10702960 m->g0=0x10702500 m->gsignal=0x10702460
>> panic during panic
>>
>> runtime stack:
>> runtime.startpanic()
>> /usr/local/go/src/pkg/runtime/panic.c:408 +0xc4
>> runtime.throw(0x523963)
>> /usr/local/go/src/pkg/runtime/panic.cBuild complete, duration
>> 14m49.452484131s. Result: error: exit status 3
>>
>> On Fri, Jun 27, 2014 at 4:47 PM,  <gobot@golang.org> wrote:
>> > This CL appears to have broken the linux-arm-cheney-panda builder.
>> > See
>> http://build.golang.org/log/f372bb09490047621c00bd8aa10bd0d6b54f9815
>> >
>> >
>> > https://codereview.appspot.com/108150043/
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups
>> > "golang-codereviews" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> > email to golang-codereviews+unsubscribe@googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>