Issue 10814043: code review 10814043: lib9: restore printing of signed integers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10814043: code review 10814043: lib9: restore printing of signed integers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:
r

CC:
iant, golang-dev

Visibility:
Public.

Description

lib9: restore printing of signed integers A casualty of https://codereview.appspot.com/10195044. If x is an 32-bit int and u is a 64-bit ulong, u = (uint)x // converts to uint before extension, so zero fills u = (ulong)x // sign-extends

Patch Set 1 #

Patch Set 2 : diff -r c224c549a3c7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c224c549a3c7 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/lib9/fmt/dofmt.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-06-30 23:53:23 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=8189dd44a170 *** lib9: restore printing of signed integers A casualty of https://codereview.appspot.com/10195044. ...

12 years ago (2013-06-30 23:53:43 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages