Issue 108110046: code review 108110046: go.exp/fsnotify: fix Plan 9 and Solaris builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108110046: code review 108110046: go.exp/fsnotify: fix Plan 9 and Solaris builds

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by aram

Modified:
11 years, 9 months ago

Reviewers:
dave, 0intro

CC:
golang-codereviews, 0intro, dave_cheney.net

Visibility:
Public.

Description

go.exp/fsnotify: fix Plan 9 and Solaris builds

Patch Set 1 #

Patch Set 2 : diff -r 93897be904a1 https://code.google.com/p/go #

Patch Set 3 : diff -r 93897be904a1 https://code.google.com/p/go #

Patch Set 4 : diff -r 93897be904a1 https://code.google.com/p/go #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
M	fsnotify/example_test.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	fsnotify/fsnotify.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	fsnotify/fsnotify_test.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

aram

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 9 months ago (2014-06-22 15:21:21 UTC) #1

aram

Hello golang-codereviews@googlegroups.com (cc: dfc, golang-codereviews@googlegroups.com), Please take another look.

11 years, 9 months ago (2014-06-22 15:26:45 UTC) #2

dave_cheney.net

LGTM. On Mon, Jun 23, 2014 at 2:52 AM, <0intro@gmail.com> wrote: > LGTM on Plan ...

11 years, 9 months ago (2014-06-22 23:40:40 UTC) #4

dave_cheney.net

11 years, 9 months ago (2014-06-22 23:44:02 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=bd8df7009305&repo=exp ***

go.exp/fsnotify: fix Plan 9 and Solaris builds

LGTM=0intro, dave
R=golang-codereviews, 0intro
CC=dave, golang-codereviews
https://codereview.appspot.com/108110046

Committer: Dave Cheney <dave@cheney.net>

Expand All Messages | Collapse All Messages