Issue 108110045: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 108110045: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by janek

Modified:
9 years, 10 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters It makes more sense to use X-parents than Y-parents for horizontal alignment. To be able to do this, we have to ensure that X-parents of MultiMeasureRestNumber, MultiMeasureRestText and PercentRepeatCounter won't be overwritten by set_bound (these grobs are spanners). We can do this because parents of these grobs are spanners as well. Expected changes in output: none.

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -13 lines)			Patch
M	lily/include/self-alignment-interface.hh	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/multi-measure-rest-engraver.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/percent-repeat-engraver.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/self-alignment-interface.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	lily/spanner.cc	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	scm/define-grobs.scm	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

janek

On 2014/06/24 05:42:36, Keith wrote: > looks good, and logical. Yay! Thanks :)

9 years, 10 months ago (2014-06-24 06:32:58 UTC) #2

janek

9 years, 10 months ago (2014-06-29 07:53:06 UTC) #3

pushed as

commit f4d8c77fc2ebac49bbdb0d0e9bec636313508846
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Mon Apr 8 15:58:08 2013 +0200

    use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters
    
    It makes more sense to use X-parents than Y-parents for horizontal
    alignment. To be able to do this, we have to ensure that X-parents of
    MultiMeasureRestNumber, MultiMeasureRestText and PercentRepeatCounter
    won't be overwritten by set_bound (these grobs are spanners).  We can
    do this because parents of these grobs are spanners as well.
    
    Expected changes in output: none.

Expand All Messages | Collapse All Messages