Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1011)

Issue 108110043: Extending: 2.3.2 - Music Function usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by pkx166h
Modified:
9 years, 8 months ago
Reviewers:
dak, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Extending: 2.3.2 - Music Function usage Issue 3955 Added words to sentences for clarity. (Hopefully) Improved sentence syntax and some minor grammer nits.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Trevor's suggestions #

Total comments: 10

Patch Set 3 : David K's suggestions - please check as I don't really understand this technically. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M Documentation/extending/programming-interface.itely View 1 2 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7
Trevor Daniels
Alternative suggestion. Trevor https://codereview.appspot.com/108110043/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/108110043/diff/1/Documentation/extending/programming-interface.itely#newcode341 Documentation/extending/programming-interface.itely:341: parse them unambiguously. The result a ...
9 years, 9 months ago (2014-06-22 16:54:04 UTC) #1
pkx166h
Trevor's suggestions
9 years, 9 months ago (2014-06-22 17:47:48 UTC) #2
pkx166h
Thanks Trevor https://codereview.appspot.com/108110043/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/108110043/diff/1/Documentation/extending/programming-interface.itely#newcode341 Documentation/extending/programming-interface.itely:341: parse them unambiguously. The result a music ...
9 years, 9 months ago (2014-06-22 18:03:00 UTC) #3
dak
https://codereview.appspot.com/108110043/diff/20001/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/108110043/diff/20001/Documentation/extending/programming-interface.itely#newcode337 Documentation/extending/programming-interface.itely:337: @node Music function usage I think I'm responsible for ...
9 years, 9 months ago (2014-06-23 07:46:24 UTC) #4
pkx166h
David K's suggestions - please check as I don't really understand this technically.
9 years, 8 months ago (2014-06-25 21:14:37 UTC) #5
pkx166h
Thanks David, Please check my changes as I really don't pretend to understand this other ...
9 years, 8 months ago (2014-06-25 21:16:29 UTC) #6
pkx166h
9 years, 8 months ago (2014-07-02 18:01:15 UTC) #7
authorJames Lowe <pkx166h@gmail.com>
 Sat, 21 Jun 2014 11:48:55 +0000 (12:48 +0100)
committerJames Lowe <pkx166h@gmail.com>
 Wed, 2 Jul 2014 17:52:11 +0000 (18:52 +0100)
commitefbd70007a36271965a57cd45a2ecad5eabb1c1c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b