Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 10809045: 11n updates - MCS Operational set and applying comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by gbadawy
Modified:
10 years, 6 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

11n updates - MCS Operational set and applying comments

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+1489 lines, -274 lines) Patch
M CHANGES.html View 1 chunk +22 lines, -0 lines 0 comments Download
M RELEASE_NOTES View 1 chunk +1 line, -0 lines 0 comments Download
A examples/wireless/ht-wifi-network.cc View 1 chunk +244 lines, -0 lines 1 comment Download
M src/mesh/model/dot11s/airtime-metric.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/network/model/packet-tag-list.h View 1 chunk +1 line, -1 line 1 comment Download
M src/wifi/doc/wifi.rst View 3 chunks +24 lines, -1 line 1 comment Download
M src/wifi/examples/wifi-phy-test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/wifi/helper/yans-wifi-helper.cc View 2 chunks +3 lines, -1 line 1 comment Download
M src/wifi/model/aarf-wifi-manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/aarfcd-wifi-manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/amrr-wifi-manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/wifi/model/ap-wifi-mac.cc View 5 chunks +44 lines, -4 lines 0 comments Download
M src/wifi/model/arf-wifi-manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/cara-wifi-manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wifi/model/constant-rate-wifi-manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wifi/model/ht-capabilities.h View 2 chunks +56 lines, -17 lines 1 comment Download
M src/wifi/model/ht-capabilities.cc View 4 chunks +232 lines, -41 lines 1 comment Download
M src/wifi/model/ideal-wifi-manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/interference-helper.cc View 3 chunks +4 lines, -2 lines 1 comment Download
M src/wifi/model/mac-low.cc View 18 chunks +22 lines, -22 lines 0 comments Download
M src/wifi/model/mgt-headers.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/minstrel-wifi-manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/nist-error-rate-model.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/onoe-wifi-manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/wifi/model/rraa-wifi-manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wifi/model/sta-wifi-mac.cc View 6 chunks +49 lines, -3 lines 1 comment Download
M src/wifi/model/supported-rates.cc View 9 chunks +17 lines, -28 lines 0 comments Download
M src/wifi/model/wifi-mac-header.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/wifi/model/wifi-mode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-phy.h View 3 chunks +30 lines, -7 lines 0 comments Download
M src/wifi/model/wifi-phy.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M src/wifi/model/wifi-remote-station-manager.h View 8 chunks +29 lines, -10 lines 0 comments Download
M src/wifi/model/wifi-remote-station-manager.cc View 23 chunks +223 lines, -42 lines 0 comments Download
M src/wifi/model/wifi-tx-vector.h View 2 chunks +29 lines, -9 lines 0 comments Download
M src/wifi/model/wifi-tx-vector.cc View 1 chunk +81 lines, -9 lines 0 comments Download
M src/wifi/model/yans-wifi-channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/yans-wifi-phy.h View 5 chunks +16 lines, -9 lines 0 comments Download
M src/wifi/model/yans-wifi-phy.cc View 12 chunks +314 lines, -26 lines 1 comment Download
M src/wifi/test/tx-duration-test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Tommaso Pecorella
Fantastic, I'll have it tested as soon as possible. Beware of the Copyright messages tho. ...
10 years, 9 months ago (2013-07-05 22:24:29 UTC) #1
Tom Henderson
https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-network.cc File examples/wireless/ht-wifi-network.cc (right): https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-network.cc#newcode18 examples/wireless/ht-wifi-network.cc:18: * Author: Mirko Banchi <mk.banchi@gmail.com> the author (perhaps copyright) ...
10 years, 9 months ago (2013-07-15 13:48:59 UTC) #2
gbadawy
On 2013/07/15 13:48:59, Tom Henderson wrote: > https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-network.cc > File examples/wireless/ht-wifi-network.cc (right): > > https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-network.cc#newcode18 ...
10 years, 9 months ago (2013-07-16 13:20:42 UTC) #3
gbadawy
Hi Hazem, Can you please clarify what does it doesn't work mean? Thanks, Ghada On ...
10 years, 6 months ago (2013-10-08 14:13:38 UTC) #4
gbadawy
Hi Hazem, The standard states that an 11n STA should be able to send/receive packets ...
10 years, 6 months ago (2013-10-09 19:44:12 UTC) #5
gbadawy
10 years, 6 months ago (2013-10-17 19:21:24 UTC) #6 
To solve this problem I have to change the rate control algorithms to
support 11n. In AarfWifiManager the wifimanager only uses rates from
OperationalRateSet but with the 11n added now stations have an
OperationalMcsSet that holds MCSs that the station support. So should I
make the WifiManager go through the MCSs first if it is an HT station then
through the data rates or should we write a new rate control algorithm
specific to HT stations?

Regards,
Ghada


On Wed, Oct 9, 2013 at 4:08 PM, hazem anwar <hazemanwar@gmail.com> wrote:

>  Thank you Ghada for your time, and I really appreciate if you can keep
> me updated.
>
> Thanks,
> Hazem
>
>
> On 09/10/13 1:43 PM, Ghada Badawy wrote:
>
> Hi Hazem,
> The standard states that an 11n STA should be able to send/receive packets
> sent using clause 18 and 19 data rates (which makes the minimum supported
> rate DSSS 1 Mbps) but the AckTimeout value (given in the standard too) is
> shorter than the tx duration of an ACK frame using DSSS 1Mbps. So the
> AckTimeOut timer expires before receiving an Ack. So no communication
> happens between both nodes
>
>  I will check and see how can I solve that and get back to you
>
>  Regards,
> Ghada
>
>
>  On Tue, Oct 8, 2013 at 11:28 PM, hazem anwar <hazemanwar@gmail.com>wrote:
>
>>  Hello Ghada,
>>
>> I just forgot to mention that, unlike *ConstantRateWifiManager, *the
>> output throughput
>> using* AarfWifiManage *is always zero. This is again due to the fact
>> that the transmitting
>> node with *AarfWifiManage *keeps sending ARP requests but never sends
>> any packets !
>>
>> Thank you again for your help !
>>
>> Hazem Gomaa
>>
>>
>>
>> On 08/10/13 9:14 PM, hazem anwar wrote:
>>
>>  Hello Ghada,
>>
>> Thank you for your prompt response and for your effort in developing *
>> 802.11n*.
>>
>> Here is my problem in details. In *ht-wifi-network.cc* , I’m trying to
>> replace *ConstantRateWifiManager *
>> with *AarfWifiManage*, as shown in the code below.
>>
>> With *AarfWifiManage*, the transmitting node simply doesn’t transmit any
>> packets, while
>> *ConstantRateWifiManager* it works fine, as shown in the attached
>> tracing files.
>> Note also that I usually use *ConstantRateWifiManager* and *
>> AarfWifiManage* with *802.11a*,
>> and they both works fine. What do I miss in *802.11n* scenario?
>>
>> Please let me know if you need further clarifications.
>> Thank you for your time !
>>
>> Hazem Gomaa
>>
>> **************************  *ht-wifi-network.cc *
>> *****************************
>> .
>> .
>> .
>> .
>> 117   else if (i == 4)
>> 118      {
>> 119        DataRate = StringValue("OfdmRate72_2MbpsBW20MHz");
>> 120        datarate = 72.2;
>> 121      }
>> 122
>> 123    /* These original 2 lines are commented by Hazem Gomaa
>> 124        wifi.SetRemoteStationManager
>> ("ns3::ConstantRateWifiManager","DataMode", DataRate,
>> 125                                  "ControlMode", DataRate);
>> 126    */
>> 127    wifi.SetRemoteStationManager ("ns3::AarfWifiManager"); //This line
>> is added by Hazem Gomaa: why it's not working !!
>> 128
>> 129       mac.SetType ("ns3::StaWifiMac",
>> 120                 "Ssid", SsidValue (ssid),
>> 131                 "ActiveProbing", BooleanValue (false));
>> .
>> .
>> .
>> .
>> *******************************************************
>>
>> On 08/10/13 8:12 AM, Ghada Badawy wrote:
>>
>> Hi Hazem,
>> Can you please clarify what does it doesn't work mean?
>>
>>  Thanks,
>> Ghada
>>
>>
>>  On Tue, Oct 8, 2013 at 12:31 AM, hazem anwar <hazemanwar@gmail.com>wrote:
>>
>>> I'm trying to use the same code in ht-wifi-network. However, I need to
>>> use AarfWifiManager instead of the ConstantRateWifiManager.
>>> For some reason, it doesn't work ! any help ?
>>>
>>>  Thanks,
>>> Hazem
>>>
>>>
>>> On Monday, July 15, 2013 7:49:00 AM UTC-6, Tom Henderson wrote:
>>>
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-netw...
>>>> File examples/wireless/ht-wifi-network.cc (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-netw...
>>>>
>>>>
examples/wireless/ht-wifi-network.cc:18<https://codereview.appspot.com/10809045/diff/1/examples/wireless/ht-wifi-network.cc#newcode18examples/wireless/ht-wifi-network.cc:18>:
>>>> * Author: Mirko Banchi
>>>>  <mk.b...@gmail.com>
>>>>  the author (perhaps copyright) should be extended to add your name,
>>>> so
>>>> authorship is clearer.
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/network/model/packet-tag-l...
>>>> File src/network/model/packet-tag-list.h (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/network/model/packet-tag-l...
>>>>
>>>>
src/network/model/packet-tag-list.h:37<https://codereview.appspot.com/10809045/diff/1/src/network/model/packet-tag-list.h#newcode37src/network/model/packet-tag-list.h:37>:
>>>> #define PACKET_TAG_MAX_SIZE 200
>>>> This will need some discussion on the list (not likely to be approved
>>>> to
>>>> be changed to such a high number).  20 bytes is chosen to reduce memory
>>>> footprint.
>>>>
>>>> Can you avoid making any change to the packet tags?
>>>>
>>>> https://codereview.appspot.com/10809045/diff/1/src/wifi/doc/wifi.rst
>>>> File src/wifi/doc/wifi.rst (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/doc/wifi.rst#newcode237
>>>>
>>>>
src/wifi/doc/wifi.rst:237<https://codereview.appspot.com/10809045/diff/1/src/wifi/doc/wifi.rst#newcode237src/wifi/doc/wifi.rst:237>:
>>>> supports creation of MAC instances that have
>>>> 802.11n-style High thtoughput (Ht) and QoS support enabled.
>>>> throughput is misspelled.
>>>>
>>>> Also, it would help here to clarify exactly which components are
>>>> changed
>>>> when user selects "HtWifiMacHelper" vs WifiMacHelper.  Why was this not
>>>> done with the existing WifiMacHelper, just expressed as a different
>>>> type?  Clarify this design point here.
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/helper/yans-wifi-help...
>>>> File src/wifi/helper/yans-wifi-helper.cc (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/helper/yans-wifi-help...
>>>>
>>>>
src/wifi/helper/yans-wifi-helper.cc:313<https://codereview.appspot.com/10809045/diff/1/src/wifi/helper/yans-wifi-helper.cc#newcode313src/wifi/helper/yans-wifi-helper.cc:313>:
>>>> //header.SetTxPower (txPower);
>>>> do not leave commented out code here; delete
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/ht-capabilities.h
>>>> File src/wifi/model/ht-capabilities.h (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/ht-capabilities...
>>>>
>>>>
src/wifi/model/ht-capabilities.h:46<https://codereview.appspot.com/10809045/diff/1/src/wifi/model/ht-capabilities.h#newcode46src/wifi/model/ht-capabilities.h:46>:
>>>> uint16_t GetHtCapabilitiesInfo
>>>> (void) const;
>>>> Doxygen missing here.
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/interference-he...
>>>> File src/wifi/model/interference-helper.cc (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/interference-he...
>>>>
>>>>
src/wifi/model/interference-helper.cc:148<https://codereview.appspot.com/10809045/diff/1/src/wifi/model/interference-helper.cc#newcode148src/wifi/model/interference-helper.cc:148>:
>>>> txvector);
>>>> why this naming change?  seems like the original was correct.
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/sta-wifi-mac.cc
>>>> File src/wifi/model/sta-wifi-mac.cc (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/sta-wifi-mac.cc...
>>>>
>>>>
src/wifi/model/sta-wifi-mac.cc:566<https://codereview.appspot.com/10809045/diff/1/src/wifi/model/sta-wifi-mac.cc#newcode566src/wifi/model/sta-wifi-mac.cc:566>:
>>>> //   m_stationManager->AddBasicMcs
>>>> (mcs);
>>>> delete
>>>>
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/yans-wifi-phy.cc
>>>> File src/wifi/model/yans-wifi-phy.cc (right):
>>>>
>>>>
https://codereview.appspot.com/10809045/diff/1/src/wifi/model/yans-wifi-phy.c...
>>>>
>>>>
src/wifi/model/yans-wifi-phy.cc:1029<https://codereview.appspot.com/10809045/diff/1/src/wifi/model/yans-wifi-phy.cc#newcode1029src/wifi/model/yans-wifi-phy.cc:1029>:
>>>> if (id == 63500000)
>>>> should 63500000 be some kind of defined constant?  Also below (where
>>>> all
>>>> the literals are expressed in the switch statement).
>>>>
>>>> https://codereview.appspot.com/10809045/
>>>>
>>>
>>
>>
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b