Issue 107890043: Resolve port conflicts in cf-dea

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107890043: Resolve port conflicts in cf-dea

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by johnsca

Modified:
9 years, 11 months ago

Reviewers:
benjamin.saller, mp+222670

Visibility:
Public.

Description

Resolve port conflicts in cf-dea https://code.launchpad.net/~johnsca/charms/trusty/cf-dea/port-conflicts/+merge/222670 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Resolve port conflicts in cf-dea #

Patch Set 3 : Resolve port conflicts in cf-dea #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -93 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/contexts.py	View		3 chunks	+17 lines, -6 lines	0 comments	Download
M	hooks/charmhelpers/core/services.py	View		9 chunks	+123 lines, -72 lines	0 comments	Download
M	hooks/config.py	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	metadata.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	templates/dea.yml	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	templates/dea_logging_agent.json	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnsca

9 years, 11 months ago (2014-06-12 18:06:40 UTC) #4

*** Submitted:

Resolve port conflicts in cf-dea

R=benjamin.saller
CC=
https://codereview.appspot.com/107890043

Expand All Messages | Collapse All Messages