code review 10784043: runtime: fix memory leaks due to defers

runtime: fix memory leaks due to defers
fn can clearly hold a closure in memory.
argp/pc point into stack and so can hold
in memory a block that was previously
a large stack serment.

[dvyukov, 2013-06-29 13:04:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2013-06-29 13:05:31]

It should help with a somewhat common idiom:
x, cleanup := foo()
defer cleanup()
Currently anything referenced by cleanup is not collected with high probability.

[dave_cheney.net, 2013-06-29 13:06:03]

wow.

On Sat, Jun 29, 2013 at 11:05 PM,  <dvyukov@google.com> wrote:
> It should help with a somewhat common idiom:
> x, cleanup := foo()
> defer cleanup()
> Currently anything referenced by cleanup is not collected with high
> probability.
>
>
> https://codereview.appspot.com/10784043/
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[rsc, 2013-07-01 21:35:50]

LGTM

[rsc, 2013-07-01 21:36:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=0f6938710930 ***

runtime: fix memory leaks due to defers
fn can clearly hold a closure in memory.
argp/pc point into stack and so can hold
in memory a block that was previously
a large stack serment.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/10784043

Committer: Russ Cox <rsc@golang.org>

[remyoudompheng, 2013-07-20 21:19:32]

R=close