Fixes image markup for ReST alongwith the resize markup

Fixes image markup for ReST alongwith the resize markup

[TheSheep, 2013-06-29 10:48:51]

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py
File MoinMoin/converter/rst_in.py (right):

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py#n...
MoinMoin/converter/rst_in.py:342: attr[name] = node.get(keyword) if
node.get(keyword) else None
attr[name] = node.get(keyword) or None

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py#n...
MoinMoin/converter/rst_in.py:351: query_keys.update(url_decode(url.query))
query_keys = url_decode(url.query)

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py#n...
MoinMoin/converter/rst_in.py:352: query = url_encode(query_keys,
charset=CHARSET, encode_keys=True)
this makes no sense, it does nothing

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py#n...
MoinMoin/converter/rst_in.py:353: url.query = None if query == u'' else query
url.query = query or None

[sharky93, 2013-06-29 11:06:20]

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py
File MoinMoin/converter/rst_in.py (right):

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py#n...
MoinMoin/converter/rst_in.py:352: query = url_encode(query_keys,
charset=CHARSET, encode_keys=True)
i dont understand ? this does the encode ?
On 2013/06/29 10:48:51, TheSheep wrote:
> this makes no sense, it does nothing

[TheSheep, 2013-06-29 11:11:30]

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py
File MoinMoin/converter/rst_in.py (right):

https://codereview.appspot.com/10782043/diff/1/MoinMoin/converter/rst_in.py#n...
MoinMoin/converter/rst_in.py:352: query = url_encode(query_keys,
charset=CHARSET, encode_keys=True)

if url.scheme is None:
    url.scheme = u'wiki.local'
    query_keys = url_decode(url.query)
    query_keys['do'] = 'get'
    url.query = url_encode(query_keys, charset=CHARSET, encode_keys=True)

[TheSheep, 2013-06-29 11:37:42]

https://codereview.appspot.com/10782043/diff/9001/MoinMoin/converter/rst_in.py
File MoinMoin/converter/rst_in.py (right):

https://codereview.appspot.com/10782043/diff/9001/MoinMoin/converter/rst_in.p...
MoinMoin/converter/rst_in.py:350: query_keys = url_decode(url.query)
query_keys = url_decode(url.query or '')    and drop the if

[sharky93, 2013-06-30 07:55:05]

Doubts with the 'scale' attribute

https://codereview.appspot.com/10782043/diff/14001/MoinMoin/converter/rst_in.py
File MoinMoin/converter/rst_in.py (right):

https://codereview.appspot.com/10782043/diff/14001/MoinMoin/converter/rst_in....
MoinMoin/converter/rst_in.py:335: whitelist = ['width', 'height', 'scale',
'alt']
How do we handle 'scale'? With the html ns is fine?

How to treat that in the HTML emitter as well?

[TheSheep, 2013-06-30 18:22:24]

https://codereview.appspot.com/10782043/diff/21001/MoinMoin/converter/rst_in.py
File MoinMoin/converter/rst_in.py (right):

https://codereview.appspot.com/10782043/diff/21001/MoinMoin/converter/rst_in....
MoinMoin/converter/rst_in.py:342: if scalingfactor:
if node.get('scale'):
    scaling_factor = node.get('scale') / 100.0
    for key in ('width', 'height'):
        if attr[html(key)]:
            attr[html(key)] *= scaling_factor