Issue 107650043: code review 107650043: go.tools/go/loader: use new types.TypeAndValue mode pre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107650043: code review 107650043: go.tools/go/loader: use new types.TypeAndValue mode pre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by adonovan

Modified:
9 years, 10 months ago

Reviewers:
gri

CC:
gri, pcc, golang-codereviews

Visibility:
Public.

Description

go.tools/go/loader: use new types.TypeAndValue mode predicates. PackageInfo: - deleted IsType - inlined + deleted: ValueOf, TypeCaseVar, ImportSpecPkg - on failure, TypeOf accessor now returns nil (was: panic) go/ssa: avoid extra map lookups by using Uses or Defs directly when safe to do so, and keeping the TypeAndValue around in expr0().

Patch Set 1 #

Patch Set 2 : diff -r ff53fb7093a1 https://code.google.com/p/go.tools/ #

Patch Set 3 : diff -r 1094193fa120 https://code.google.com/p/go.tools/ #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -136 lines)			Patch
M	go/loader/pkginfo.go	View	2 chunks	+10 lines, -72 lines	0 comments	Download
M	go/ssa/builder.go	View	15 chunks	+35 lines, -29 lines	0 comments	Download
M	go/ssa/create.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	go/ssa/func.go	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	go/ssa/ssa.go	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	oracle/callees.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	oracle/describe.go	View	7 chunks	+16 lines, -9 lines	0 comments	Download
M	oracle/freevars.go	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	refactor/eg/eg.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	refactor/eg/match.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools/

9 years, 10 months ago (2014-07-09 09:59:50 UTC) #1

adonovan

9 years, 10 months ago (2014-07-11 09:50:12 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=c7ed95187f53&repo=tools ***

go.tools/go/loader: use new types.TypeAndValue mode predicates.

PackageInfo:
- deleted IsType
- inlined + deleted: ValueOf, TypeCaseVar, ImportSpecPkg
- on failure, TypeOf accessor now returns nil (was: panic)

go/ssa: avoid extra map lookups by using Uses or Defs directly when safe to do
so,
and keeping the TypeAndValue around in expr0().

LGTM=gri
R=gri, pcc
CC=golang-codereviews
https://codereview.appspot.com/107650043

Expand All Messages | Collapse All Messages