Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(168)

Issue 107630043: code review 107630043: ogle/dwarf/debug: add PCToSPOffset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by r
Modified:
7 years, 5 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/dwarf/debug: add PCToSPOffset Allows us to discover the offset from the stack pointer to the virtual frame pointer. The DWARF machine does a lot more than this. Our implementation handles only what gc'ed Go binaries include.

Patch Set 1 #

Total comments: 26

Patch Set 2 : diff -r 5ff4bcb86e53 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -1 line) Patch
M debug/dwarf/buf.go View 2 chunks +10 lines, -0 lines 0 comments Download
A debug/dwarf/frame.go View 1 chunk +293 lines, -0 lines 0 comments Download
A debug/dwarf/frame_test.go View 1 chunk +122 lines, -0 lines 0 comments Download
M debug/dwarf/pclntab_test.go View 1 chunk +1 line, -1 line 0 comments Download
A debug/dwarf/testdata/pcsptest.go View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 5 months ago (2014-07-08 20:49:57 UTC) #1
nigeltao
LGTM. https://codereview.appspot.com/107630043/diff/1/debug/dwarf/frame.go File debug/dwarf/frame.go (right): https://codereview.appspot.com/107630043/diff/1/debug/dwarf/frame.go#newcode42 debug/dwarf/frame.go:42: // Call Frame instructions.Figure 40, page 181. s/s.F/s. ...
7 years, 5 months ago (2014-07-09 06:31:48 UTC) #2
r
https://codereview.appspot.com/107630043/diff/1/debug/dwarf/frame.go File debug/dwarf/frame.go (right): https://codereview.appspot.com/107630043/diff/1/debug/dwarf/frame.go#newcode42 debug/dwarf/frame.go:42: // Call Frame instructions.Figure 40, page 181. On 2014/07/09 ...
7 years, 5 months ago (2014-07-09 17:57:11 UTC) #3
r
7 years, 5 months ago (2014-07-09 17:57:27 UTC) #4
*** Submitted as https://code.google.com/p/ogle/source/detail?r=bad9b3a11146 ***

ogle/dwarf/debug: add PCToSPOffset
Allows us to discover the offset from the stack pointer to the
virtual frame pointer.

The DWARF machine does a lot more than this. Our implementation
handles only what gc'ed Go binaries include.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/107630043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b