Add initial implementation of Comment itemtype.

Add initial implementation of Comment itemtype.

There is no convenient form to add a new comment yet (it could be created the same way as any other wiki item).
No styles.

!!!ATTENTION: Patch Set 3: please check only the following:
 * items/comment.py
 * templates/comment/utils.html

[Thomas.J.Waldmann, 2013-06-28 22:45:30]

https://codereview.appspot.com/10761044/diff/1/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

https://codereview.appspot.com/10761044/diff/1/MoinMoin/items/__init__.py#new...
MoinMoin/items/__init__.py:693: comment_items = [Item.create(rev.name) for rev
in revs]
as a general hint: be careful with creating potentially lots of item object in
parallel. think about whether this is really needed.

https://codereview.appspot.com/10761044/diff/1/MoinMoin/items/__init__.py#new...
MoinMoin/items/__init__.py:710: comments=comments,
maybe this could be more dynamic later, so that comments are only loaded on
request and/or via ajax.

https://codereview.appspot.com/10761044/diff/1/MoinMoin/items/comment.py
File MoinMoin/items/comment.py (right):

https://codereview.appspot.com/10761044/diff/1/MoinMoin/items/comment.py#newc...
MoinMoin/items/comment.py:19: reply_to = OptionalText.using(label=L_("Reply
to")).with_properties(placeholder=L_("Item UUID"))
using "Item UUID" for both?

https://codereview.appspot.com/10761044/diff/1/MoinMoin/templates/comment/uti...
File MoinMoin/templates/comment/utils.html (right):

https://codereview.appspot.com/10761044/diff/1/MoinMoin/templates/comment/uti...
MoinMoin/templates/comment/utils.html:5: {{
comment_item.content._render_data()|safe }}
maybe you could create the comment_item here (using its itemid), so only 1
exists at a time.

is the |safe needed (do we do that at other places with _render_data() also?).

[Thomas.J.Waldmann, 2013-07-15 22:27:10]

ok

https://codereview.appspot.com/10761044/diff/10001/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

https://codereview.appspot.com/10761044/diff/10001/MoinMoin/items/__init__.py...
MoinMoin/items/__init__.py:687: Term(COMMENT_FOR, self.meta[ITEMID]),
somehow itemtype comment and comment_for are both checking that this is a
comment. not sure how to improve that, though.

can a item have comment_for without being itemtype_comment?

[spy, 2013-07-26 17:34:42]

On 2013/07/15 22:27:10, Thomas.J.Waldmann wrote:
> ok
> 
> https://codereview.appspot.com/10761044/diff/10001/MoinMoin/items/__init__.py
> File MoinMoin/items/__init__.py (right):
> 
>
https://codereview.appspot.com/10761044/diff/10001/MoinMoin/items/__init__.py...
> MoinMoin/items/__init__.py:687: Term(COMMENT_FOR, self.meta[ITEMID]),
> somehow itemtype comment and comment_for are both checking that this is a
> comment. not sure how to improve that, though.
> 
> can a item have comment_for without being itemtype_comment?

Yes, any item can have "comment_for" meta added through 'Extra MetaData (JSON)'
field and obviously it is not validated.

I have updated a CR, please check only the following:
 * items/comment.py
 * templates/comment/utils.html

[ReimarBauer, 2013-07-27 11:55:18]

a question added

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/items/comment.py
File MoinMoin/items/comment.py (right):

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/items/comment.py#...
MoinMoin/items/comment.py:23: ((unicode(Type(e.content_type,
parameters=e.default_contenttype_params)), e.display_name)
why explicitly unicode type casting? can it be something else?

[spy, 2013-07-28 15:08:48]

answered

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/items/comment.py
File MoinMoin/items/comment.py (right):

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/items/comment.py#...
MoinMoin/items/comment.py:23: ((unicode(Type(e.content_type,
parameters=e.default_contenttype_params)), e.display_name)
On 2013/07/27 11:55:18, ReimarBauer wrote:
> why explicitly unicode type casting? can it be something else?

I want to define a mapping between valid contenttype values and their human
names exactly the same way we do in 
http://hg.moinmo.in/moin/2.0/file/78ed0ce6b718/MoinMoin/templates/modify_sele...

Maybe it is not a good way to hardcode those values in the form definition. We
can check them in an appropriate validator and the mapping between some of
possible contenttype values and their names pass directly to the rendered
template.

[ReimarBauer, 2013-07-28 17:42:46]

a question about a comment

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/templates/comment...
File MoinMoin/templates/comment/utils.html (right):

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/templates/comment...
MoinMoin/templates/comment/utils.html:3: {# TODO: check the item isn't
nonexistent #}
you mean check if the item does not exist? 

"isn't nonexistent" is the same as exists, or?

[Thomas.J.Waldmann, 2013-07-29 22:48:58]

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/items/__init__.py...
MoinMoin/items/__init__.py:402: update_meta = {key:value for key, value in
update_meta.items() if value is not None}
key: value

pep8

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/templates/comment...
File MoinMoin/templates/comment/utils.html (right):

https://codereview.appspot.com/10761044/diff/24001/MoinMoin/templates/comment...
MoinMoin/templates/comment/utils.html:3: {# TODO: check the item isn't
nonexistent #}
yeah, please fix.