Issue 107600043: code review 107600043: cmd/pack: skip test on android (no Go tool)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107600043: code review 107600043: cmd/pack: skip test on android (no Go tool) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by crawshaw

Modified:
10 years, 11 months ago

Reviewers:
gobot, minux

CC:
golang-codereviews, minux

Visibility:
Public.

Description

cmd/pack: skip test on android (no Go tool)

Patch Set 1 #

Patch Set 2 : diff -r 690153652172 https://code.google.com/p/go #

Patch Set 3 : diff -r 690153652172 https://code.google.com/p/go #

Patch Set 4 : diff -r b44d5295b040 https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/cmd/pack/pack_test.go	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

crawshaw

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-07-08 14:48:34 UTC) #1

crawshaw

*** Submitted as https://code.google.com/p/go/source/detail?r=17da47e64205 *** cmd/pack: skip test on android (no Go tool) LGTM=minux R=golang-codereviews, ...

10 years, 11 months ago (2014-07-08 17:44:57 UTC) #3

gobot

10 years, 11 months ago (2014-07-08 21:00:03 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/e2cda1330ac8df10d0d8cf8f77aed1913c5736ee

Expand All Messages | Collapse All Messages