Issue 10758043: code review 10758043: runtime: shorten hash lookup stack frames

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10758043: code review 10758043: runtime: shorten hash lookup stack frames (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: shorten hash lookup stack frames On amd64 the frames are very close to the limit for a nosplit (textflag 7) function, in part because the C compiler does not make any attempt to reclaim space allocated for completely registerized variables. Avoid a few short-lived variables to reclaim two words.

Patch Set 1 #

Patch Set 2 : diff -r fccd815ed3bb https://go.googlecode.com/hg #

Patch Set 3 : diff -r fccd815ed3bb https://go.googlecode.com/hg #

Patch Set 4 : diff -r 1e659829d22a https://go.googlecode.com/hg #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -22 lines)			Patch
	M	src/pkg/runtime/hashmap_fast.c	View	1	4 chunks	+18 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years ago (2013-06-28 18:50:37 UTC) #1

rsc

12 years ago (2013-06-28 20:37:11 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=473048d1cd3a ***

runtime: shorten hash lookup stack frames

On amd64 the frames are very close to the limit for a
nosplit (textflag 7) function, in part because the C compiler
does not make any attempt to reclaim space allocated for
completely registerized variables. Avoid a few short-lived
variables to reclaim two words.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10758043

Expand All Messages | Collapse All Messages