Issue 107570043: code review 107570043: undo CL 107160049 / 9abbb23a14f6

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107570043: code review 107570043: undo CL 107160049 / 9abbb23a14f6 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by gmk

Modified:
11 years, 6 months ago

Reviewers:
gri

CC:
gri, adonovan, golang-codereviews

Visibility:
Public.

Description

undo CL 107160049 / 9abbb23a14f6 This method was deemed unfit for the API. See the original CL for discussion. ««« original CL description go.tools/go/loader: Add Program.FilePath convenience method for getting the full path of a source file. LGTM=gri R=gri, adonovan CC=golang-codereviews https://codereview.appspot.com/107160049 Committer: Robert Griesemer <gri@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 536b79981a09 https://code.google.com/p/go.tools #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	go/loader/loader.go	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gmk

Hello gri@golang.org, adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 6 months ago (2014-07-07 19:53:27 UTC) #1

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=9c948bd8b6d9&repo=tools *** undo CL 107160049 / 9abbb23a14f6 This method was deemed unfit ...

11 years, 6 months ago (2014-07-07 21:02:35 UTC) #3

adonovan

11 years, 6 months ago (2014-07-07 22:29:55 UTC) #4

Thanks, Gordon.


On 7 July 2014 17:02, <gri@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=9c948bd8b6d9&repo=tools ***
>
>
> undo CL 107160049 / 9abbb23a14f6
>
> This method was deemed unfit for the API.  See the original CL for
> discussion.
>
> ««« original CL description
> go.tools/go/loader: Add Program.FilePath convenience method for getting
> the full path of a source file.
>
> LGTM=gri
> R=gri, adonovan
> CC=golang-codereviews
> https://codereview.appspot.com/107160049
>
> Committer: Robert Griesemer <gri@golang.org>
> »»»
>
> LGTM=gri
> R=gri, adonovan
> CC=golang-codereviews
> https://codereview.appspot.com/107570043
>
> Committer: Robert Griesemer <gri@golang.org>
>
>
> https://codereview.appspot.com/107570043/
>

Expand All Messages | Collapse All Messages