DescriptionUpdate makefile template and css build targets.
- The template targets didn't take into account the subapps directory.
- There was no direct target watching css files. Since they're built as part
of the templates I think it's typical for a template change to accompany css
changes and it wasn't noticed there was a corner case.
QA
--
To QA you need to run `make build-prod`. Once that is done, run it again and
see that it does not rerun any builders on the template/css targets.
Then, touch a template in the subapps directory and make build-prod again.
`touch app/subapps/browser/templates/minimized.handlebars && make build-prod`
Run build-prod again and see that there's no change. Then touch a less file
and verify the makefile catches it as changed and rebuilds.
`touch lib/views/browser/charm-token.less && make build-prod`
https://code.launchpad.net/~rharding/juju-gui/makefile-updates/+merge/172117
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 1
Patch Set 2 : Update makefile template and css build targets. #MessagesTotal messages: 4
|