Issue 10746043: Split test_sandbox.js into pieces.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10746043: Split test_sandbox.js into pieces.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by teknico

Modified:
10 years, 9 months ago

Reviewers:
mp+172042, frankban, jeff.pihach

Visibility:
Public.

Description

Split test_sandbox.js into pieces. The test_sandbox.js file is too big, 2200+ lines and 75 KByte. This splits the Go and Python sandbox tests out of it into test_sandbox_go.js and test_sandbox_python.js . Only the ClientConnection tests are left there. Huge diff unavoidably, but it only moves code around, no other changes, I promise. :-) https://code.launchpad.net/~teknico/juju-gui/split-sandbox-test-file/+merge/172042 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Split test_sandbox.js into pieces. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2079 lines, -2030 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/index.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/test_sandbox.js	View		1 chunk	+0 lines, -2030 lines	0 comments	Download
A	test/test_sandbox_go.js	View		1 chunk	+728 lines, -0 lines	0 comments	Download
A	test/test_sandbox_python.js	View		1 chunk	+1347 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

teknico

10 years, 9 months ago (2013-06-28 15:08:00 UTC) #4

*** Submitted:

Split test_sandbox.js into pieces.

The test_sandbox.js file is too big, 2200+ lines and 75 KByte.

This splits the Go and Python sandbox tests out of it into
test_sandbox_go.js and test_sandbox_python.js . Only the ClientConnection
tests are left there.

Huge diff unavoidably, but it only moves code around, no other changes,
I promise. :-)

R=jeff.pihach, frankban
CC=
https://codereview.appspot.com/10746043

Expand All Messages | Collapse All Messages