Added subscribe and quicklink option in ticket's base.html

Added subscribe and quicklink option in ticket's base.html

[dimazest, 2014-07-04 08:12:27]

https://codereview.appspot.com/107440046/diff/60001/MoinMoin/items/ticket.py
File MoinMoin/items/ticket.py (right):

https://codereview.appspot.com/107440046/diff/60001/MoinMoin/items/ticket.py#...
MoinMoin/items/ticket.py:208: item=self,
if you pass self, there is not need to pas fqname, because you will be able to
access it as item.fqname

[Thomas.J.Waldmann, 2014-07-05 16:30:02]

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
File MoinMoin/templates/ticket/base.html (right):

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:42: {% set exists = item.fqname and
storage.get_item(**item.fqname.query) %}
check if there is a more direct way to use storage api to detect "exists"

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:51: <a href="{{
url_for('frontend.quicklink_item', item_name=item.fqname) }}"
class="list-group-item" rel="nofollow" title="Create or remove a navigation link
to this item">
we wanted tickets to be nameless, so you use a tickets name to create a link to
it?

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:52: <i class="icon-star-empty
icon-fixed-width"> </i>
is that space inside needed for something?

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:59: <a href="{{
url_for('frontend.subscribe_item', item_name=item.fqname) }}"
class="list-group-item" rel="nofollow" title="witch notifications about item
changes on or off">
same here

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:60: <i class="icon-envelope
icon-fixed-width"> </i>
is that space inside needed for something?

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:76: <a href="{{
url_for('frontend.quicklink_item', item_name=item.fqname) }}" title="Create or
remove a navigation link to this item" rel="nofollow">
same here

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:85: <a href="{{
url_for('frontend.subscribe_item', item_name=item.fqname) }}" title="Switch
notifications about item changes on or off" rel="nofollow">
same here

[sksaurabhkathpalia, 2014-07-05 16:38:21]

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
File MoinMoin/templates/ticket/base.html (right):

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:51: <a href="{{
url_for('frontend.quicklink_item', item_name=item.fqname) }}"
class="list-group-item" rel="nofollow" title="Create or remove a navigation link
to this item">
On 2014/07/05 16:30:02, Thomas.J.Waldmann wrote:
> we wanted tickets to be nameless, so you use a tickets name to create a link
to
> it?

we are passing fqname as this way only we can get link.
In quicklink function it is received as fqname only. I have tested it, it works
completely fine :)

https://codereview.appspot.com/107440046/diff/100001/MoinMoin/templates/ticke...
MoinMoin/templates/ticket/base.html:60: <i class="icon-envelope
icon-fixed-width"> </i>
On 2014/07/05 16:30:02, Thomas.J.Waldmann wrote:
> is that space inside needed for something?

Oh sorry
I will remove the space in my next commit as this is already committed