Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 10743046: code review 10743046: cmd/gc: support x[i:j:k] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by rsc
Modified:
4 years, 4 months ago
Reviewers:
r, DMorsing, bradfitz, btracey
CC:
golang-dev, r
Visibility:
Public.

Description

cmd/gc: support x[i:j:k] Design doc at golang.org/s/go12slice. This is an experimental feature and may not be included in the release.

Patch Set 1 #

Patch Set 2 : diff -r fccd815ed3bb https://code.google.com/p/go/ #

Patch Set 3 : diff -r fccd815ed3bb https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 8189dd44a170 https://code.google.com/p/go/ #

Patch Set 5 : diff -r ef3ed5705640 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1537 lines, -1095 lines) Patch
M src/cmd/5g/cgen.c View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/6g/cgen.c View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/8g/cgen.c View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/gc/esc.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/fmt.c View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/go.y View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M src/cmd/gc/racewalk.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 3 4 chunks +92 lines, -44 lines 0 comments Download
M src/cmd/gc/walk.c View 1 7 chunks +74 lines, -12 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 61 chunks +1051 lines, -1035 lines 0 comments Download
M src/cmd/gc/yerr.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/issue4251.go View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A test/slice3.go View 1 1 chunk +156 lines, -0 lines 0 comments Download
A test/slice3err.go View 1 2 3 4 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 11
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 4 months ago (2013-06-28 22:05:08 UTC) #1
r
https://codereview.appspot.com/10743046/diff/6001/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/10743046/diff/6001/src/cmd/gc/typecheck.c#newcode1802 src/cmd/gc/typecheck.c:1802: yyerror("inverted slice index %N > %N", lo, hi); not ...
4 years, 4 months ago (2013-07-01 17:02:39 UTC) #2
rsc
PTAL https://codereview.appspot.com/10743046/diff/6001/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/10743046/diff/6001/src/cmd/gc/typecheck.c#newcode1802 src/cmd/gc/typecheck.c:1802: yyerror("inverted slice index %N > %N", lo, hi); ...
4 years, 4 months ago (2013-07-01 21:26:57 UTC) #3
r
LGTM as an experiment. y.tab.c won't load in codereview
4 years, 4 months ago (2013-07-01 23:52:28 UTC) #4
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=ed9fb0ef363c *** cmd/gc: support x[i:j:k] Design doc at golang.org/s/go12slice. This is an ...
4 years, 4 months ago (2013-07-02 00:32:41 UTC) #5
bradfitz
Open season? What are the rules? Specifically: are performance-related CLs acceptable? On Mon, Jul 1, ...
4 years, 4 months ago (2013-07-02 00:44:07 UTC) #6
rsc
Wait for Rob, but I believe it is okay to use in the tree in ...
4 years, 4 months ago (2013-07-02 01:21:58 UTC) #7
btracey
Just curious, what has changed since https://code.google.com/p/go/issues/detail?id=4371&can=1&q=brendan&colspec=ID%20Status%20Stars%20Priority%20Owner%20Reporter%20Summary On Monday, July 1, 2013 9:21:57 PM UTC-4, ...
4 years, 4 months ago (2013-07-02 13:31:58 UTC) #8
DMorsing
On 2013/07/02 13:31:58, tracey.brendan_gmail.com wrote: > Just curious, what has changed since > > https://code.google.com/p/go/issues/detail?id=4371&can=1&q=brendan&colspec=ID%2520Status%2520Stars%2520Priority%2520Owner%2520Reporter%2520Summary ...
4 years, 4 months ago (2013-07-02 13:41:37 UTC) #9
btracey
I hadn't seen that, thank you
4 years, 4 months ago (2013-07-02 14:01:33 UTC) #10
r
4 years, 4 months ago (2013-07-03 01:45:14 UTC) #11
Brad: Enjoy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4