Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(363)

Issue 107390044: code review 107390044: bufio: Fixed call to Fatal, should be Fatalf.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by tnt
Modified:
10 years, 11 months ago
Reviewers:
iant
CC:
golang-codereviews, iant, bradfitz
Visibility:
Public.

Description

bufio: Fixed call to Fatal, should be Fatalf.

Patch Set 1 #

Patch Set 2 : diff -r 4db0802fd3fd https://code.google.com/p/go/ #

Patch Set 3 : diff -r 86b431eeb5c2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/bufio/scan_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
tnt
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 11 months ago (2014-07-01 23:04:01 UTC) #1
iant
LGTM Thanks.
10 years, 11 months ago (2014-07-02 13:41:39 UTC) #2
iant
Have you signed the CLA?
10 years, 11 months ago (2014-07-02 13:42:10 UTC) #3
bradfitz
Yes. I processed it for Camlistore previously. Submitting for Go .... On Jul 2, 2014 ...
10 years, 11 months ago (2014-07-02 13:45:42 UTC) #4
iant
10 years, 11 months ago (2014-07-02 14:04:06 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=0f766178488c ***

bufio: Fixed call to Fatal, should be Fatalf.

LGTM=iant
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/107390044

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b