Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(128)

Issue 107280044: code review 107280044: syscall: consolidate, simplify socket options for Unix-... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by mikio
Modified:
8 years, 1 month ago
Reviewers:
aram
CC:
golang-codereviews, aram
Visibility:
Public.

Description

syscall: consolidate, simplify socket options for Unix-like systems Also exposes common socket option functions on Solaris. Update issue 7174 Update issue 7175

Patch Set 1 : diff -r 36ffbae640bd https://code.google.com/p/go #

Patch Set 2 : diff -r 36ffbae640bd https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -92 lines) Patch
M src/pkg/syscall/syscall_bsd.go View 1 chunk +0 lines, -42 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 2 chunks +0 lines, -34 lines 0 comments Download
M src/pkg/syscall/syscall_unix.go View 3 chunks +58 lines, -16 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 1 month ago (2014-06-23 09:27:32 UTC) #1
aram
LGTM
8 years, 1 month ago (2014-06-23 09:28:44 UTC) #2
mikio
8 years, 1 month ago (2014-06-23 09:46:10 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=ee11f19bc514 ***

syscall: consolidate, simplify socket options for Unix-like systems

Also exposes common socket option functions on Solaris.

Update issue 7174
Update issue 7175

LGTM=aram
R=golang-codereviews, aram
CC=golang-codereviews
https://codereview.appspot.com/107280044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b