Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6043)

Issue 107270043: code review 107270043: runtime/race: support freebsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by dvyukov
Modified:
9 years, 10 months ago
Reviewers:
aram, iant
CC:
golang-codereviews, iant, dfc
Visibility:
Public.

Description

runtime/race: support freebsd All tests pass except one test in regexp package.

Patch Set 1 #

Patch Set 2 : diff -r 18b60d104c30 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 18b60d104c30 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 18b60d104c30 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/cmd/go/build.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/go/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/race/race.go View 1 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/runtime/race/race_freebsd_amd64.syso View 1 Binary file 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 10 months ago (2014-06-20 23:58:25 UTC) #1
iant
LGTM
9 years, 10 months ago (2014-06-21 00:02:12 UTC) #2
dfc
YAY! Is there a bug logged for the test failure? Is it the race runtime, ...
9 years, 10 months ago (2014-06-21 00:03:21 UTC) #3
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=bb2f58dbe604 *** runtime/race: support freebsd All tests pass except one test in ...
9 years, 10 months ago (2014-06-21 00:21:26 UTC) #4
aram
9 years, 10 months ago (2014-06-21 11:20:34 UTC) #5
Message was sent while issue was closed.
What would it take to support Solaris?

Basically how do I create the syso file?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b