Issue 107170043: Deny closing a running event loop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107170043: Deny closing a running event loop

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by haypo_gmail

Modified:
9 years, 10 months ago

Reviewers:
saghul

CC:
haypo_gmail

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 3

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -3 lines)			Patch
M	asyncio/base_events.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	asyncio/proactor_events.py	View	1 chunk	+1 line, -1 line	2 comments	Download
M	asyncio/selector_events.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	asyncio/unix_events.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_events.py	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

saghul

https://codereview.appspot.com/107170043/diff/1/asyncio/proactor_events.py File asyncio/proactor_events.py (right): https://codereview.appspot.com/107170043/diff/1/asyncio/proactor_events.py#newcode358 asyncio/proactor_events.py:358: super().close() Shouldn't super().close() already cover returningearly if the loop ...

9 years, 10 months ago (2014-06-17 08:24:10 UTC) #1

haypo_gmail

9 years, 10 months ago (2014-06-17 08:49:41 UTC) #2

https://codereview.appspot.com/107170043/diff/1/asyncio/proactor_events.py
File asyncio/proactor_events.py (right):

https://codereview.appspot.com/107170043/diff/1/asyncio/proactor_events.py#ne...
asyncio/proactor_events.py:358: super().close()
On 2014/06/17 08:24:10, saghul wrote:
> Shouldn't super().close() already cover returningearly if the loop was closed?

super().close() does nothing if the event loop is already close, but it doesn't
avoid to call _close_self_pipe() in this function for example.

Expand All Messages | Collapse All Messages