Issue 107160046: code review 107160046: cmd/5c, cmd/6c, cmd/8c, cmd/cc: remove unused global va...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107160046: code review 107160046: cmd/5c, cmd/6c, cmd/8c, cmd/cc: remove unused global va... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by minux

Modified:
10 years, 12 months ago

Reviewers:
bradfitz

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Description

cmd/5c, cmd/6c, cmd/8c, cmd/cc: remove unused global variable retok.

Patch Set 1 #

Patch Set 2 : diff -r 62285adb2b50 https://code.google.com/p/go #

Patch Set 3 : diff -r 62285adb2b50 https://code.google.com/p/go #

Patch Set 4 : diff -r 7f0999348917 https://code.google.com/p/go #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
M	src/cmd/5c/gc.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/6c/gc.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/8c/gc.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/cc/pgen.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 12 months ago (2014-06-17 06:03:25 UTC) #1

bradfitz

LGTM On Jun 16, 2014 11:03 PM, <minux@golang.org> wrote: > Reviewers: golang-codereviews, > > Message: ...

10 years, 12 months ago (2014-06-17 06:04:23 UTC) #2

LGTM
 On Jun 16, 2014 11:03 PM, <minux@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/5c, cmd/6c, cmd/8c, cmd/cc: remove unused global variable retok.
>
> Please review this at https://codereview.appspot.com/107160046/
>
> Affected files (+0, -5 lines):
>   M src/cmd/5c/gc.h
>   M src/cmd/6c/gc.h
>   M src/cmd/8c/gc.h
>   M src/cmd/cc/pgen.c
>
>
> Index: src/cmd/5c/gc.h
> ===================================================================
> --- a/src/cmd/5c/gc.h
> +++ b/src/cmd/5c/gc.h
> @@ -144,7 +144,6 @@
>  EXTERN int32   maxargsafe;
>  EXTERN int     mnstring;
>  EXTERN Multab  multab[20];
> -EXTERN int     retok;
>  extern int     hintabsize;
>  EXTERN Node*   nodrat;
>  EXTERN Node*   nodret;
> Index: src/cmd/6c/gc.h
> ===================================================================
> --- a/src/cmd/6c/gc.h
> +++ b/src/cmd/6c/gc.h
> @@ -143,7 +143,6 @@
>  EXTERN Prog*   lastp;
>  EXTERN int32   maxargsafe;
>  EXTERN int     mnstring;
> -EXTERN int     retok;
>  EXTERN Node*   nodrat;
>  EXTERN Node*   nodret;
>  EXTERN Node*   nodsafe;
> Index: src/cmd/8c/gc.h
> ===================================================================
> --- a/src/cmd/8c/gc.h
> +++ b/src/cmd/8c/gc.h
> @@ -143,7 +143,6 @@
>  EXTERN Prog*   lastp;
>  EXTERN int32   maxargsafe;
>  EXTERN int     mnstring;
> -EXTERN int     retok;
>  EXTERN Node*   nodrat;
>  EXTERN Node*   nodret;
>  EXTERN Node*   nodsafe;
> Index: src/cmd/cc/pgen.c
> ===================================================================
> --- a/src/cmd/cc/pgen.c
> +++ b/src/cmd/cc/pgen.c
> @@ -155,8 +155,6 @@
>                 }
>         }
>
> -       retok = 0;
> -
>         canreach = 1;
>         warnreach = 1;
>         gen(n);
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

minux

10 years, 12 months ago (2014-06-17 06:05:30 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=528a025b902b ***

cmd/5c, cmd/6c, cmd/8c, cmd/cc: remove unused global variable retok.

LGTM=bradfitz
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/107160046

Expand All Messages | Collapse All Messages