code review 107150043: syscall: implement setresuid(2) and setresgid(2) on Ope...

syscall: implement setresuid(2) and setresgid(2) on OpenBSD/FreeBSD/DragonflyBSD

Fixes issue 8218.

[worr, 2014-06-16 13:47:52]

syscall: implement setresuid(2) and setresgid(2) on OpenBSD

Fixes issue 8218.

[iant, 2014-06-16 16:36:07]

Can you also regenerate zsyscall_openbsd_386.go?

[minux, 2014-06-16 19:11:52]

I've updated the summary of the issue, please replace "Fixes issue 8218." with
this:
Update issue 8128
Summary: syscall: setresuid(2) and setresgid(2) unimplemented on
FreeBSD/DragonflyBSD

Note: no period on the update issue line.

[worr, 2014-06-16 19:26:28]

On 2014/06/16 19:11:52, minux wrote:
> I've updated the summary of the issue, please replace "Fixes issue 8218." with
> this:
> Update issue 8128
> Summary: syscall: setresuid(2) and setresgid(2) unimplemented on
> FreeBSD/DragonflyBSD
> 
> Note: no period on the update issue line.

I'll come back with a patch that fixes it on all the affected platforms as well

[worr, 2014-06-17 01:27:01]

Hello golang-dev@googlegroups.com, iant@golang.org, minux@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2014-06-17 01:30:14]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[minux, 2014-06-17 01:34:12]

you will also need to generate zsyscall for freebsd/arm.

[worr, 2014-06-17 01:38:10]

Hello golang-codereviews@googlegroups.com, iant@golang.org, minux@golang.org
(cc: golang-codereviews@googlegroups.com),

Please take another look.

[iant, 2014-06-24 20:29:59]

LGTM

[iant, 2014-06-24 20:30:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=caa2646daa63 ***

syscall: implement setresuid(2) and setresgid(2) on OpenBSD/FreeBSD/DragonflyBSD

Fixes issue 8218.

LGTM=iant
R=golang-codereviews, iant, minux
CC=golang-codereviews
https://codereview.appspot.com/107150043

Committer: Ian Lance Taylor <iant@golang.org>

[worr, 2014-09-20 04:41:39]

*** Abandoned ***