Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 10707045: code review 10707045: misc/emacs: Add godef-jump-other-window (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by Dominik Honnef
Modified:
11 years, 11 months ago
Reviewers:
adonovan
CC:
golang-dev, adonovan
Visibility:
Public.

Description

misc/emacs: Add godef-jump-other-window This will behave like similar "*-other-window" functions in Emacs. Default key bind is C-x 4 C-c C-j – while awkward, it follows both the convention for other-window functions and the convention for not using user- or emacs-reserved keys.

Patch Set 1 #

Patch Set 2 : diff -r 166d946fa77f https://code.google.com/p/go #

Patch Set 3 : diff -r 166d946fa77f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M misc/emacs/go-mode.el View 1 5 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6
Dominik Honnef
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-06-28 13:50:21 UTC) #1
Dominik Honnef
Ping. Related: I realize that changes to misc/emacs have low priority and are probably somewhat ...
11 years, 11 months ago (2013-07-10 07:58:35 UTC) #2
adonovan
LGTM > Related: I realize that changes to misc/emacs have low priority and are > ...
11 years, 11 months ago (2013-07-10 12:13:20 UTC) #3
Dominik Honnef
On 2013/07/10 12:13:20, adonovan wrote: > LGTM > > > Related: I realize that changes ...
11 years, 11 months ago (2013-07-10 12:50:44 UTC) #4
Dominik Honnef
Want to commit? Unfortunately I am not permitted to ;)
11 years, 11 months ago (2013-07-17 21:44:50 UTC) #5
adonovan
11 years, 11 months ago (2013-07-17 22:16:47 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=e49eb0bc44bc ***

misc/emacs: Add godef-jump-other-window

This will behave like similar "*-other-window" functions in Emacs.

Default key bind is C-x 4 C-c C-j – while awkward, it follows both
the convention for other-window functions and the convention for
not using user- or emacs-reserved keys.

R=golang-dev, adonovan
CC=golang-dev
https://codereview.appspot.com/10707045

Committer: Alan Donovan <adonovan@google.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b