Issue 10700045: code review 10700045: go.net/ipv4: make IANA registry parser robust

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10700045: code review 10700045: go.net/ipv4: make IANA registry parser robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by mikio

Modified:
11 years, 8 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

go.net/ipv4: make IANA registry parser robust - specify complete resource path to avoid receiving xhtml - make use of keyword instead of table index

Patch Set 1 #

Patch Set 2 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Patch Set 3 : diff -r fae782e541a6 https://code.google.com/p/go.net #

Total comments: 2

Patch Set 4 : diff -r 1e0ed6fb3a20 https://code.google.com/p/go.net #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	ipv4/gen.go	View	1 2 3	3 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 8 months ago (2013-06-28 07:27:05 UTC) #1

dave_cheney.net

LGTM. This looks pretty straight forward as this is a generator for code we already ...

11 years, 8 months ago (2013-06-28 13:08:40 UTC) #2

mikio

11 years, 8 months ago (2013-06-29 01:25:23 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=3739e7941262&repo=net ***

go.net/ipv4: make IANA registry parser robust

- specify complete resource path to avoid receiving xhtml
- make use of keyword instead of table index

R=dave
CC=golang-dev
https://codereview.appspot.com/10700045

https://codereview.appspot.com/10700045/diff/6001/ipv4/gen.go
File ipv4/gen.go (right):

https://codereview.appspot.com/10700045/diff/6001/ipv4/gen.go#newcode129
ipv4/gen.go:129: }
On 2013/06/28 13:08:40, dfc wrote:
> should you bail out here if id is still zero ?

Done.

Expand All Messages | Collapse All Messages