Issue 10696043: code review 10696043: runtime: fix goroutine status corruption

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10696043: code review 10696043: runtime: fix goroutine status corruption (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by dvyukov

Modified:
12 years ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix goroutine status corruption runtime.entersyscall() sets g->status = Gsyscall, then calls runtime.lock() which causes stack split. runtime.newstack() resets g->status to Grunning. This will lead to crash during GC (world is not stopped) or GC will scan stack incorrectly.

Patch Set 1 #

Patch Set 2 : diff -r 3a9551481ad1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3a9551481ad1 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 8648a001bbca https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 8648a001bbca https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	src/pkg/runtime/stack.c	View	1 2 3	6 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years ago (2013-06-27 17:52:35 UTC) #1

rsc

https://codereview.appspot.com/10696043/diff/6001/src/pkg/runtime/stack.c File src/pkg/runtime/stack.c (right): https://codereview.appspot.com/10696043/diff/6001/src/pkg/runtime/stack.c#newcode157 src/pkg/runtime/stack.c:157: oldstatus = gp->status; move to top of block: // ...

12 years ago (2013-06-27 20:16:10 UTC) #2

dvyukov

On 2013/06/27 20:16:10, rsc wrote: > https://codereview.appspot.com/10696043/diff/6001/src/pkg/runtime/stack.c > File src/pkg/runtime/stack.c (right): > > https://codereview.appspot.com/10696043/diff/6001/src/pkg/runtime/stack.c#newcode157 > ...

12 years ago (2013-06-27 20:39:19 UTC) #3

dvyukov

12 years ago (2013-06-27 20:50:01 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=cf7a2eb3a4d4 ***

runtime: fix goroutine status corruption
runtime.entersyscall() sets g->status = Gsyscall,
then calls runtime.lock() which causes stack split.
runtime.newstack() resets g->status to Grunning.
This will lead to crash during GC (world is not stopped) or GC will scan stack
incorrectly.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/10696043

Expand All Messages | Collapse All Messages