Issue 10694043: Do not show /sidebar in the url for charmid urls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10694043: Do not show /sidebar in the url for charmid urls

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rharding

Modified:
10 years, 10 months ago

Reviewers:
j.c.sackett, mp+171865, gary.poster

Visibility:
Public.

Description

Do not show /sidebar in the url for charmid urls - If the viewmode is the default (sidebar) and we don't need the viewmode for search routes to hit, just skip it. https://code.launchpad.net/~rharding/juju-gui/sidebar-default-1191160/+merge/171865 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Do not show /sidebar in the url for charmid urls #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	test/test_browser_app.js	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

j.c.sackett

LGTM, with two minor fixes. https://codereview.appspot.com/10694043/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/10694043/diff/1/app/subapps/browser/browser.js#newcode91 app/subapps/browser/browser.js:91: // urlParts.push(this._viewState.viewmode); Delete this? ...

10 years, 10 months ago (2013-06-27 17:21:05 UTC) #2

gary.poster

LGTM with Jon's comments addressed. Thanks! Gary https://codereview.appspot.com/10694043/diff/1/app/subapps/browser/browser.js File app/subapps/browser/browser.js (right): https://codereview.appspot.com/10694043/diff/1/app/subapps/browser/browser.js#newcode91 app/subapps/browser/browser.js:91: // urlParts.push(this._viewState.viewmode); ...

10 years, 10 months ago (2013-06-27 17:36:26 UTC) #3

rharding

10 years, 10 months ago (2013-06-27 17:45:04 UTC) #4

*** Submitted:

Do not show /sidebar in the url for charmid urls

- If the viewmode is the default (sidebar) and we don't need the viewmode for
search routes to hit, just skip it.

R=j.c.sackett, gary.poster
CC=
https://codereview.appspot.com/10694043

Expand All Messages | Collapse All Messages