Issue 10691043: Add support for reviewed icons on related charms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10691043: Add support for reviewed icons on related charms.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rharding

Modified:
10 years, 10 months ago

Reviewers:
curtis, j.c.sackett, mp+171862

Visibility:
Public.

Description

Add support for reviewed icons on related charms. - Add a new 17px png for the tiny charm token sized widget - Adjust the css to get that icon in the right place and looking consistent. - Make sure we pass the is_approved data down into the widget. https://code.launchpad.net/~rharding/juju-gui/missing-star/+merge/171862 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for reviewed icons on related charms. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/badge_approved_17.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/models/charm.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/views/browser/charm-token.less	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	test/test_model.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

10 years, 10 months ago (2013-06-27 18:48:37 UTC) #4

*** Submitted:

Add support for reviewed icons on related charms.

- Add a new 17px png for the tiny charm token sized widget
- Adjust the css to get that icon in the right place and looking consistent.
- Make sure we pass the is_approved data down into the widget.

R=j.c.sackett, curtis
CC=
https://codereview.appspot.com/10691043

Expand All Messages | Collapse All Messages