Issue 10690044: code review 10690044: libregexp: update from Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10690044: code review 10690044: libregexp: update from Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by 0intro

Modified:
10 years, 10 months ago

Reviewers:
rsc

CC:
rsc

Visibility:
Public.

Description

libregexp: update from Plan 9

Patch Set 1 #

Patch Set 2 : diff -r e9630856f49b https://code.google.com/p/plan9port/ #

Patch Set 3 : diff -r e9630856f49b https://code.google.com/p/plan9port/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
M	src/libregexp/regcomp.h	View	1	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/libregexp/regcomp.c	View	1	5 chunks	+17 lines, -6 lines	0 comments	Download
M	src/libregexp/regsub.c	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/libregexp/test.c	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/libregexp/test2.c	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port/

10 years, 10 months ago (2013-06-27 19:23:13 UTC) #1

0intro

10 years, 10 months ago (2013-07-02 04:39:26 UTC) #3

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=0b4301229060 ***

libregexp: update from Plan 9

R=rsc
https://codereview.appspot.com/10690044

Expand All Messages | Collapse All Messages