Generalized version of create_user()

Username, password and email are required params.
Email is left for compatibility with old usages (see `MoinMoin/_tests/test_user.py`).

`validate=True` and `is_encrypted=False` don't belong to meta, so maybe we should leave them as default arguments.

[Thomas.J.Waldmann, 2013-06-28 13:58:29]

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py
File MoinMoin/user.py (left):

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py#oldcode93
MoinMoin/user.py:93: theuser.profile[DISABLED] = is_disabled
you need to handle the default (False) correctly here, too, so you need a
.get(..., False).

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py#oldcode95
MoinMoin/user.py:95: # save data
yeah, that comment is rather superfluous, thanks for removing it.

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py#newcode55
MoinMoin/user.py:55: validate = kw.get("validate")
if you are not giving True as default value for .get(), you change behaviour.

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py#newcode74
MoinMoin/user.py:74: is_encrypted = kw.get("is_encrypted")
default should be False here (using None as falsish would work, but is ugly)

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py#newcode90
MoinMoin/user.py:90: openid = kw.get(OPENID)
here the default is and was None, so this is correct.

https://codereview.appspot.com/10688044/diff/1/MoinMoin/user.py#newcode94
MoinMoin/user.py:94: for meta, meta_value in kw.items():
name it "key, value", not "meta, meta_value"

note: we need more formal validation here later, preferably using flatland. add
a comment about this.

currently you can give all sort of rubbish and it happily stores them into user
profile.

when we have flatland validation, we can also deal with name and email there, so
this code will get much easier and prettier.

[Thomas.J.Waldmann, 2013-06-28 14:25:15]

mostly ok, add more docs

also, as usual: run tests, try it practically.

https://codereview.appspot.com/10688044/diff/6001/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/10688044/diff/6001/MoinMoin/user.py#newcode50
MoinMoin/user.py:50: """ create a user """
the docstring should have much more info now as it isn't obvious any more from
the signature of the method.

use reST markup as sphinx wants it.

[Thomas.J.Waldmann, 2013-06-28 15:16:59]

https://codereview.appspot.com/10688044/diff/1002/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/10688044/diff/1002/MoinMoin/user.py#newcode52
MoinMoin/user.py:52: 
in general: reST usually has a colon before and after, like:

:param foo: description of the foo param

(and no dash afterwards)

https://codereview.appspot.com/10688044/diff/1002/MoinMoin/user.py#newcode54
MoinMoin/user.py:54: :param password - user's password
... - see also is_encrypted param

https://codereview.appspot.com/10688044/diff/1002/MoinMoin/user.py#newcode56
MoinMoin/user.py:56: :param validate - when True (default) will validate
username, password, email
"if True"?

https://codereview.appspot.com/10688044/diff/1002/MoinMoin/user.py#newcode60
MoinMoin/user.py:60: :param meta - a dictionary of key-value pairs that
represent user metadata
... that are put into user profile metadata.

[Thomas.J.Waldmann, 2013-06-28 15:43:41]

https://codereview.appspot.com/10688044/diff/16001/MoinMoin/user.py
File MoinMoin/user.py (right):

https://codereview.appspot.com/10688044/diff/16001/MoinMoin/user.py#newcode58
MoinMoin/user.py:58: :param is_encrypted: when False (default) defines that the
password is in
if False...

https://codereview.appspot.com/10688044/diff/16001/MoinMoin/user.py#newcode61
MoinMoin/user.py:61: will be stored to user profile metadata
into

[Thomas.J.Waldmann, 2013-06-28 15:49:51]

ok