worker/deployer: Use loggo for logging

worker/deployer: Use loggo for logging

Following up on https://codereview.appspot.com/10617043/,
this small CL replaces the juju's log package with loggo,
as suggested in the previous CL's review.

Next down the line is a cleanup branch to handle better
upgrades from before the deployer is removed from the 
unit agent to the current state (handling upstart conf
files for both cases and being able to recall previously
deployed units).

https://code.launchpad.net/~dimitern/juju-core/060-deployer-use-loggo/+merge/171778

(do not edit description out of merge proposal)

[dimitern, 2013-06-27 11:49:36]

Please take a look.

[jameinel, 2013-06-27 13:40:28]

LGTM except I don't think we want to set the log level.
It should get set on the root, but individual loggers just inherit that if they
don't set something else.

https://codereview.appspot.com/10681044/diff/1/worker/deployer/deployer.go
File worker/deployer/deployer.go (right):

https://codereview.appspot.com/10681044/diff/1/worker/deployer/deployer.go#ne...
worker/deployer/deployer.go:20: logger.SetLogLevel(loggo.TRACE)
I don't think we want to explicitly set this here. Just use the global juju log
level, so people can override it to something they deem sensible.

Otherwise when configuring juju logging level, they'll have to *unset* this
value in every configuration.

[mue, 2013-06-27 15:35:21]

LGTM with jam's hint.

https://codereview.appspot.com/10681044/diff/1/worker/deployer/deployer.go
File worker/deployer/deployer.go (right):

https://codereview.appspot.com/10681044/diff/1/worker/deployer/deployer.go#ne...
worker/deployer/deployer.go:20: logger.SetLogLevel(loggo.TRACE)
On 2013/06/27 13:40:28, jameinel wrote:
> I don't think we want to explicitly set this here. Just use the global juju
log
> level, so people can override it to something they deem sensible.
> 
> Otherwise when configuring juju logging level, they'll have to *unset* this
> value in every configuration.

+1

[dimitern, 2013-06-27 16:03:48]

Please take a look.

https://codereview.appspot.com/10681044/diff/1/worker/deployer/deployer.go
File worker/deployer/deployer.go (right):

https://codereview.appspot.com/10681044/diff/1/worker/deployer/deployer.go#ne...
worker/deployer/deployer.go:20: logger.SetLogLevel(loggo.TRACE)
On 2013/06/27 13:40:28, jameinel wrote:
> I don't think we want to explicitly set this here. Just use the global juju
log
> level, so people can override it to something they deem sensible.
> 
> Otherwise when configuring juju logging level, they'll have to *unset* this
> value in every configuration.

I wasn't sure of this either - just copied the code from the provisioner.
Removed.

[dimitern, 2013-06-27 16:07:06]

Please take a look.