Issue 10679050: code review 10679050: cmd/godoc: set up playground for examples that are alre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10679050: code review 10679050: cmd/godoc: set up playground for examples that are alre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by adg

Modified:
11 years, 11 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/godoc: set up playground for examples that are already visible This fixes an issue where linking directly to an example makes it not runnable and visible only in a tiny window. To see the bug in action, visit this link: http://golang.org/pkg/strings/#example_Map

Patch Set 1 #

Patch Set 2 : diff -r 5801a8324d45 https://code.google.com/p/go #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	doc/godocs.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/godoc/package.html	View		2 chunks	+18 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 11 months ago (2013-07-01 01:47:15 UTC) #1

adg

11 years, 11 months ago (2013-07-01 22:44:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ef3ed5705640 ***

cmd/godoc: set up playground for examples that are already visible

This fixes an issue where linking directly to an example makes it not
runnable and visible only in a tiny window. To see the bug in action,
visit this link: http://golang.org/pkg/strings/#example_Map

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10679050

Expand All Messages | Collapse All Messages