Issue 10678043: environs/localstorage: new package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10678043: environs/localstorage: new package

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by rog

Modified:
10 years, 10 months ago

Reviewers:
mue, dimitern, mp+171774

Visibility:
Public.

Description

environs/localstorage: new package We move the functionality from environs/local and export relevant methods. https://code.launchpad.net/~rogpeppe/juju-core/336-environs-localstorage/+merge/171774 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : environs/localstorage: new package #

Patch Set 3 : environs/localstorage: new package #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -105 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
D	environs/local/export_test.go	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	environs/localstorage/backend.go	View		7 chunks	+21 lines, -20 lines	0 comments	Download
M	environs/localstorage/backend_test.go	View	1 2	10 chunks	+44 lines, -51 lines	0 comments	Download
M	environs/localstorage/storage.go	View	1 2	6 chunks	+9 lines, -10 lines	0 comments	Download
M	environs/localstorage/storage_test.go	View	1 2	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

Very nice, LGTM, just one suggestion. https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend.go File environs/localstorage/backend.go (left): https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend.go#oldcode23 environs/localstorage/backend.go:23: environName string yay! ...

10 years, 10 months ago (2013-06-27 11:18:29 UTC) #2

mue

LGTM. One hint: in environs/testing.EC2HTTPTestStorage I encapsulated the listener and added a Stop() method that ...

10 years, 10 months ago (2013-06-27 12:14:51 UTC) #3

rog

10 years, 10 months ago (2013-06-27 13:41:28 UTC) #4

Please take a look.

https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_...
File environs/localstorage/backend_test.go (right):

https://codereview.appspot.com/10678043/diff/1/environs/localstorage/backend_...
environs/localstorage/backend_test.go:125: c.Assert(resp.StatusCode, Equals,
200)
On 2013/06/27 11:18:29, dimitern wrote:
> s/200/http.StatusOK/ ?

Done.

Expand All Messages | Collapse All Messages